Implement the Twitter Future cancellation protocol #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-gens
previously approved these changes
Jan 12, 2026
bpholt
force-pushed
the
twitter-future-cancelation
branch
from
7034201 to
6d48a3d
Compare
j-gens
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the lifting of Twitter
Futures into Cats EffectF[_] : Asyncto support cancellation, and improves test coverage for this behavior.liftFutureintwitter-futures/src/main/scala/com/dwolla/util/async/twitter.scalaby providing a finalizer that triggers TwitterFutureinterruption viaraise(CancelledViaCatsEffect).CancelledViaCatsEffectobject, ajava.util.concurrent.CancellationExceptionused to signal interruption from Cats Effect to Twitter'sutil.Future.recoverFromCancelledViaCatsEffectto handle a potential race condition in Cats Effect where a cancelled future might appear completed with the cancellation exception.TwitterFutureAsyncMapKTests.scalawith comprehensive tests for lifting TwitterFutures, verifying both successful completion and proper interruption propagation upon fiber cancellation.Thanks to @djspiewak for his help resolving a couple of race conditions that popped up along the way.