Conversation
* Removed '2' as a response when there was no value to respond with * NaN from parsing '' resulted in a null sent, change to '' - this is because we can't send a zilde * As above, but for an undefined case * Set initial value correctly
* Wrapping is determined by presence of line breaks * Justify is now accepted * Font CSS is passed through to Label * Sending zilde [] is now understood as omitting some style
Add readme
Small cleanup / clarity elsewhere
Add a generic WG handler when no custom one is found - simply queries what data we have in refData. Universal Size and Posn checks if they were requested and not set in the response to be returned. If not found, will query the DOM to find the size and position.
Add a generic WG handler when no custom one is found - simply queries what data we have in refData. Universal Size and Posn checks if they were requested and not set in the response to be returned. If not found, will query the DOM to find the size and position.
The many if statements formed a quasi switch statement, and as there was no default, it worked fine. I know need a default and it's easier to avoid mistakes if we use else if statements. Don't crash on invalid IDs for size and pos, return [0, 0] as sentinel values.
GetTextSize fix
Also removes package-lock.json as a side fix
Add styling to Upload and Link
Fix calculateTextDimensions
Fix more styles
We should apply this generally - maybe in inheritedProperty? The problem is that some things test inheritedProperty for a return value and then default.
Zilde explicitly clears all BCol setting
Most important point: we have complete control over the events that can be fired. For example, reselecting the same option is OK and fires an event. Also: * Attempts to look Windows-y * Supports filtering via text etc
Add Children to Div and flex/style change
Combo rewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.