handle invalid input

zavub · zavub · commit ce4dd4fbac77 · 2025-11-17T15:29:25.000-05:00
diff --git a/src/Libraries/CoreNodeModels/DropDown.cs b/src/Libraries/CoreNodeModels/DropDown.cs
@@ -230,7 +230,11 @@ public static int ParseSelectedIndexImpl(string index, IList<DynamoDropDownItem>
             }
             else
             {
-                var tempIndex = Convert.ToInt32(index);
+                if (!int.TryParse(index, out int tempIndex))
+                {
+                    return selectedIndex;
+                }
+
                 selectedIndex = tempIndex > (items.Count - 1) ?
                     -1 :
                     tempIndex;

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,11 @@ public static int ParseSelectedIndexImpl(string index, IList<DynamoDropDownItem>`
`230`	`230`	`}`
`231`	`231`	`else`
`232`	`232`	`{`
`233`		`- var tempIndex = Convert.ToInt32(index);`
	`233`	`+ if (!int.TryParse(index, out int tempIndex))`
	`234`	`+ {`
	`235`	`+ return selectedIndex;`
	`236`	`+ }`
	`237`	`+`
`234`	`238`	`selectedIndex = tempIndex > (items.Count - 1) ?`
`235`	`239`	`-1 :`
`236`	`240`	`tempIndex;`