DYN-7310 - Modify Github Crash Report to Allow for "Issue Report" from Help Menu, and "Crash Report" from Crash #15775
Conversation
Update title of github issue to "Issue Report from Dynamo" as not all issues that are getting submitted are crashes.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7310
UI Smoke TestsTest: success. 11 passed, 0 failed. |
johnpierson
changed the title
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
One comment and then LGTM
| // making sure we properly escape content since stack traces may contain characters not suitable | ||
| // for use in URLs | ||
| var title = "title=" + Uri.EscapeDataString(string.Format(issueTitle, dynamoVersion)); | ||
| var title = "title=" + Uri.EscapeDataString(string.Format(issueTitle, reportType, dynamoVersion)); |
There was a problem hiding this comment.
It's been a while, can you double check here if reportType would be number or string. I remember vaguely that the real value of Enums will be number and you may need to grab the name of the Enum specifically here.
There was a problem hiding this comment.
It appears to pull the string from the enum on the string formatting portion.
There was a problem hiding this comment.
Thank you for checking @johnpierson maybe the string.Format took care of it underneath already.
|
One last comment, then LGTM |
|
Waiting for |
|
😁
…On Thu, Jan 23, 2025 at 1:01 PM Aaron (Qilong) ***@***.***> wrote:
Waiting for SelfServe check to pass
—
Reply to this email directly, view it on GitHub
<#15775 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADYD5VBFWJGOZF7DYHFUUB32MFDBVAVCNFSM6AAAAABVVNDZKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJQHEYDKMZQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
3 participants
Purpose
Update Github Issue Title from "Crash Report" to "Issue Report" as not all issues submitted are a crash.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
@QilongTang
FYIs
@avidit