Skip to content

Conversation

@dnenov
Copy link
Collaborator

@dnenov dnenov commented Apr 4, 2025

Purpose

Continuation of #16085. Adding the replacement of 'x' with '*' to match the expected server request notation. Also, this PR is adding a notification to the front-end if the user has cancelled out during the Submit process, so the UI can correctly reflect that.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • replace 'x' with '*' before sending submit request
  • added route to notify the front end if the user cancels out during the submit action

Reviewers

@zeusongit

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

- replace 'x' with '*' before sending submit request
- added route to notify the front end if the user cancels out during the submit action
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8630

@zeusongit zeusongit added this to the 3.5 milestone Apr 4, 2025
@zeusongit zeusongit merged commit c8b1bae into DynamoDS:master Apr 4, 2025
35 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 4, 2025
@github-actions
Copy link

github-actions bot commented Apr 4, 2025

Successfully created backport PR for RC3.5.0_master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants