[DYN-8528] Can't undo changes to curve mapper #16173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8528
Contributor
|
Would you resolve the merge conflicts? |
…do-changes-to-curve-mapper_from-master
Contributor
Author
Thanks, conflicts are resolved now. |
Contributor
|
Running the job again https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/17790/, the failing test might not be related. |
Contributor
|
DynamoSelfServe #17790 was successful. Merging now. |
Contributor
|
/cherrypick |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin RC3.5.1_master
git worktree add -d .worktree/cherrypick-16173 origin/RC3.5.1_master
cd .worktree/cherrypick-16173
git switch --create cherrypick-16173
git cherry-pick -x fa8c3e2a33678c902ce5345e7950325a37ea699b |
Contributor
|
/cherrypick |
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2025
(cherry picked from commit fa8c3e2)
9 tasks
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR aims to address DYN-8528 by enabling undo on the Curve Mapper node.
Now the model is recorded to the undo/redo stack before:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Users can now undo changes in the Curve Mapper node.
Reviewers
@reddyashish
@zeusongit
FYIs
@dnenov
@achintyabhat