Skip to content

Conversation

@avidit
Copy link
Contributor

@avidit avidit commented Apr 30, 2025

Purpose

  • Remove build steps as CodeQL can analyze C# without build
  • Add analysis for language:actions
  • Run job on pull request and push to master

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

@zeusongit @QilongTang

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Comment on lines +65 to +69
name: Details
runs-on: ubuntu-latest
steps:
- name: Print details
run: echo "For details check the [CodeQL Status](https://github.com/DynamoDS/Dynamo/security/code-scanning/tools/CodeQL/status/) page" >> $GITHUB_STEP_SUMMARY

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
@avidit avidit changed the title ✨DYN-8686 Update CodeQL Analysis workflow DYN-8686 Update CodeQL Analysis workflow Apr 30, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8686

- Remove build steps as CodeQL can analyze C# without build
- Add analysis for language:actions
@avidit avidit force-pushed the feature/dyn-8686 branch from 9d79a22 to 9267d11 Compare April 30, 2025 14:49
@avidit avidit requested a review from zeusongit May 1, 2025 22:23
@avidit avidit merged commit 9365bf1 into DynamoDS:master May 2, 2025
20 of 21 checks passed
@avidit avidit deleted the feature/dyn-8686 branch May 2, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants