-
Notifications
You must be signed in to change notification settings - Fork 668
DYN-8541: Add single and cluster icons, refactor #16189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-8541: Add single and cluster icons, refactor #16189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8541
johnpierson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, with a couple of comments for renaming to better relate cluster with single. I would be curious @BogdanZavu 's thoughts too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this file to match the other one?
NodeAutoCompleteClusterResult.
So this one and the class would be NodeAutoCompleteSingleResult?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we could rename the other one to be simpler too, Eg. ClusterAutoCompleteResult and SingleAutoCompleteResult
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They have slightly different purposes, NodeAutoCompleteClusterResult is a view model for the dropdown (for both single and cluster) and SingleAutocompleteResult extracts the key necessary information from a NodeSearchElementViewModel.
So i'm renaming SingleAutocompleteResult to SingleResultItem (analog to ClusterResultItem from src\DynamoCore\Search\NodeAutocompleteSearch.cs) and NodeAutoCompleteClusterResult to DNADropdownViewModel
|
😎
…On Fri, May 9, 2025 at 6:28 PM chubakueno ***@***.***> wrote:
Merged #16189 <#16189> into master.
—
Reply to this email directly, view it on GitHub
<#16189 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADYD5VAAMN2II3HA7WN6BBL25VB3PAVCNFSM6AAAAAB4SEGTF2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXGU4TQNRXGM2TQNY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|

Purpose
Add icons to cluster and single autocomplete, refactor code to partially decouple from
NodeSearchElementViewModelandNodeSearchElement.2025-05-06.15-29-20.mp4
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Add icons to cluster and single autocomplete, partially decouple DNA code from preexisting single autocomplete code.
Reviewers
@johnpierson
@BogdanZavu
@QilongTang
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of