-
Notifications
You must be signed in to change notification settings - Fork 668
DYN-8514 Updating Documentation Mesh Nodes #16200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-8514 Updating Documentation Mesh Nodes #16200
Conversation
Due that recently the LibG nuget package with the changes related to Mesh nodes was uploaded was also updated in Dynamo csproj files, the documentation was updated so in this changes is just updating the documentation for localization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8514
aparajit-pratap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you also check if the node help docs work as expected for the newly named nodes? Some files might need to be updated.
I've added dyn/md/png files for the two nodes updated Mesh.ByPointsIndexGroups and Mesh.ByPointsIndices
I've updated the documentation in node help docs for the Mesh nodes. |
|
@RobertGlobant20, why did you need to add new files? You could have simply renamed the existing dyn's and png's for the old nodes, right? |
I think is not just renaming, I had to update the nodes in each dyn file, run the graph, generate the screenshot with the new image also update the md file pointing to the new image (renaming the existing documentation will show the wrong nodes and wrong images for the updated nodes). I can delete the old documentation but that will break the documentation for obsolete nodes. |


Purpose
Due that recently the LibG nuget package with the changes related to Mesh nodes was uploaded was also updated in Dynamo csproj files, the documentation was updated so in this changes is just updating the documentation for localization.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Due that recently the LibG nuget package with the changes related to Mesh nodes was uploaded was also updated in Dynamo csproj files, the documentation was updated so in this changes is just updating the documentation for localization.
Reviewers
@QilongTang
@aparajit-pratap
FYIs