Skip to content

Conversation

@RobertGlobant20
Copy link
Contributor

Purpose

Due that recently the LibG nuget package with the changes related to Mesh nodes was uploaded was also updated in Dynamo csproj files, the documentation was updated so in this changes is just updating the documentation for localization.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Due that recently the LibG nuget package with the changes related to Mesh nodes was uploaded was also updated in Dynamo csproj files, the documentation was updated so in this changes is just updating the documentation for localization.

Reviewers

@QilongTang
@aparajit-pratap

FYIs

Due that recently the LibG nuget package with the changes related to Mesh nodes was uploaded was also updated in Dynamo csproj files, the documentation was updated so in this changes is just updating the documentation for localization.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8514

Copy link
Contributor

@aparajit-pratap aparajit-pratap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you also check if the node help docs work as expected for the newly named nodes? Some files might need to be updated.

I've added dyn/md/png files for the two nodes updated Mesh.ByPointsIndexGroups and Mesh.ByPointsIndices
@RobertGlobant20
Copy link
Contributor Author

Screenshots of the updated documentation for the Mesh nodes.
tmNZBABKqg
EXGeHKGhb3

@RobertGlobant20
Copy link
Contributor Author

Thanks, can you also check if the node help docs work as expected for the newly named nodes? Some files might need to be updated.

I've updated the documentation in node help docs for the Mesh nodes.
commit: d2e47c3

@aparajit-pratap
Copy link
Contributor

@RobertGlobant20, why did you need to add new files? You could have simply renamed the existing dyn's and png's for the old nodes, right?

@RobertGlobant20
Copy link
Contributor Author

RobertGlobant20 commented May 12, 2025

@RobertGlobant20, why did you need to add new files? You could have simply renamed the existing dyn's and png's for the old nodes, right?

I think is not just renaming, I had to update the nodes in each dyn file, run the graph, generate the screenshot with the new image also update the md file pointing to the new image (renaming the existing documentation will show the wrong nodes and wrong images for the updated nodes).

I can delete the old documentation but that will break the documentation for obsolete nodes.

@RobertGlobant20 RobertGlobant20 merged commit d65a9c1 into DynamoDS:master May 12, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants