-
Notifications
You must be signed in to change notification settings - Fork 668
DYN-9879: Py Engine Change pops up erroneously #16747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-9879: Py Engine Change pops up erroneously #16747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9879
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where the "Hide Python engine change notifications" user preference was not being respected when displaying Python auto-migration notifications. The fix ensures that both workspace-level and preference-level settings are checked before showing notifications, and properly resets the workspace flag when workspaces are cleared.
Key Changes:
- Added preference setting check to notification display logic to respect user's "Hide" preference
- Reset
ShowPythonAutoMigrationNotificationstofalsewhen workspace is cleared to prevent stale state
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/PythonMigrationViewExtension/PythonMigrationViewExtension.cs | Resets workspace notification flag on clear and sets flag to true during migration |
| src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs | Adds preference setting check to notification display condition |
|
The failing test in https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/18960/ passes locally. |
(cherry picked from commit fc1ae8a)
|
Successfully created backport PR for |
Purpose
This PR addresses DYN-9879.
Fixes an issue where the “Hide Python engine change notifications” preference did not persist reliably.
Also ensures that
WorkspaceModel.ShowPythonAutoMigrationNotificationsis reset tofalsewhen creating new workspaces.Declarations
Check these if you believe they are true
Release Notes
Fixes an issue where the “Hide Python engine change notifications” preference did not persist reliably.
Also ensures that
WorkspaceModel.ShowPythonAutoMigrationNotificationsis reset tofalsewhen creating new workspaces.Reviewers
@zeusongit
@DynamoDS/eidos
FYIs
@dnenov
@achintyabhat
@jnealb