Skip to content

Conversation

@ivaylo-matov
Copy link
Contributor

Purpose

This PR addresses DYN-9879.

Fixes an issue where the “Hide Python engine change notifications” preference did not persist reliably.
Also ensures that WorkspaceModel.ShowPythonAutoMigrationNotifications is reset to false when creating new workspaces.

DYN-9879-fix1

DYN-9879-fix2

Declarations

Check these if you believe they are true

Release Notes

Fixes an issue where the “Hide Python engine change notifications” preference did not persist reliably.
Also ensures that WorkspaceModel.ShowPythonAutoMigrationNotifications is reset to false when creating new workspaces.

Reviewers

@zeusongit
@DynamoDS/eidos

FYIs

@dnenov
@achintyabhat
@jnealb

Copilot AI review requested due to automatic review settings November 21, 2025 11:18
@github-actions github-actions bot changed the title fix DYN-9879: fix Nov 21, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9879

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where the "Hide Python engine change notifications" user preference was not being respected when displaying Python auto-migration notifications. The fix ensures that both workspace-level and preference-level settings are checked before showing notifications, and properly resets the workspace flag when workspaces are cleared.

Key Changes:

  • Added preference setting check to notification display logic to respect user's "Hide" preference
  • Reset ShowPythonAutoMigrationNotifications to false when workspace is cleared to prevent stale state

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/PythonMigrationViewExtension/PythonMigrationViewExtension.cs Resets workspace notification flag on clear and sets flag to true during migration
src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs Adds preference setting check to notification display condition

@ivaylo-matov ivaylo-matov changed the title DYN-9879: fix DYN-9879: Py Engine Change pops up erroneously Nov 21, 2025
@ivaylo-matov
Copy link
Contributor Author

@zeusongit zeusongit requested a review from a team November 21, 2025 19:44
@zeusongit zeusongit added this to the 4.0 milestone Nov 21, 2025
@zeusongit zeusongit merged commit fc1ae8a into DynamoDS:master Nov 21, 2025
28 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 21, 2025
@github-actions
Copy link

Successfully created backport PR for RC4.0.0_master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants