Skip to content

DYN-9879: Py Engine Change pops up erroneously #16747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeusongit merged 1 commit into from
Nov 21, 2025
Merged

DYN-9879: Py Engine Change pops up erroneously #16747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1755,7 +1755,11 @@ private void DynamoViewModelRequestUserSaveWorkflow(object sender, WorkspaceSave

// Show the one-time Python Engine Change notification for the workspace
var ws = dynamoViewModel.Model.CurrentWorkspace;
if (!ws.HasShownPythonAutoMigrationNotification && ws.ShowPythonAutoMigrationNotifications)
var prefSettings = dynamoViewModel.Model.PreferenceSettings;

if (!ws.HasShownPythonAutoMigrationNotification
&& ws.ShowPythonAutoMigrationNotifications
&& prefSettings.ShowPythonAutoMigrationNotifications)
{
var cancelFirstDialogBox = ShowPythonEngineChangeNoticeAndMarkIfProceed();
if (cancelFirstDialogBox)
Expand Down
3 changes: 2 additions & 1 deletion src/PythonMigrationViewExtension/PythonMigrationViewExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ private void OnCurrentWorkspaceCleared(IWorkspaceModel workspace)
// Close the CPython toast notification when workspace is cleared/closed
DynamoViewModel.ToastManager?.CloseRealTimeInfoWindow();
lastWorkspaceGuid = Guid.Empty;
CurrentWorkspace.ShowPythonAutoMigrationNotifications = false;
}

private void OnWorkspaceRemoveStarted(IWorkspaceModel workspace)
Expand Down Expand Up @@ -515,7 +516,7 @@ private void MigrateCPythonNodesForWorkspace()
customCount,
LoadedParams.StartupParams.PathManager.BackupDirectory);

CurrentWorkspace.ShowPythonAutoMigrationNotifications = preferenceSettings.ShowPythonAutoMigrationNotifications;
CurrentWorkspace.ShowPythonAutoMigrationNotifications = true;
}
}

Expand Down
Loading