Skip to content

Conversation

@RobertGlobant20
Copy link
Contributor

@RobertGlobant20 RobertGlobant20 commented Nov 27, 2025

Purpose

Adding scrollbar in the GraphProperties (this change will make to disappear the scrollbar in the CustomProperties section).

Declarations

Check these if you believe they are true

Release Notes

Adding scrollbar in the GraphProperties (this change will make to disappear the scrollbar in the CustomProperties section).

Reviewers

@reddyashish @zeusongit @johnpierson

FYIs

Adding scrollbar in the GraphProperties (this change will make to disappear the scrollbar in the CustomProperties section).
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9855

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a scrollbar to the GraphProperties view by wrapping the main Grid in a ScrollViewer. This change shifts scroll functionality from the CustomProperties section to the entire GraphProperties panel, improving navigation when content exceeds the visible area.

</UserControl.Resources>

<Grid Margin="10px, 10px">
<ScrollViewer VerticalScrollBarVisibility="Auto">
Copy link

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ScrollViewer should specify HorizontalScrollBarVisibility to prevent unexpected horizontal scrolling behavior. Consider adding HorizontalScrollBarVisibility=\"Disabled\" to ensure content doesn't scroll horizontally, which could impact keyboard navigation and screen reader behavior.

Suggested change
<ScrollViewer VerticalScrollBarVisibility="Auto">
<ScrollViewer VerticalScrollBarVisibility="Auto" HorizontalScrollBarVisibility="Disabled">

Copilot uses AI. Check for mistakes.
@RobertGlobant20
Copy link
Contributor Author

GIF showing the expected behavior (please let me know if the scrollbar expected is ok).
DynamoSandbox_y1GetWLttW

@RobertGlobant20
Copy link
Contributor Author

Hi team, do you have any comment about this changes?

@zeusongit zeusongit merged commit 327f560 into DynamoDS:master Dec 4, 2025
28 of 30 checks passed
@zeusongit zeusongit added this to the 4.0.1 milestone Dec 15, 2025
@zeusongit
Copy link
Contributor

/cherrypick

1 similar comment
@zeusongit
Copy link
Contributor

/cherrypick

github-actions bot pushed a commit that referenced this pull request Dec 17, 2025
@github-actions
Copy link

Successfully created backport PR for RC4.0.1_master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants