DYN-6738: Gizmo Display Issues #16844

jasonstratton · 2026-01-21T03:53:33Z

Summary

update gizmo drag behavior with incremental node updates and rounding on mouse up for real-time redraw
prevent camera pan/orbit from affecting gizmo by filtering mouse events and clearing translation hit state after manipulation
queue gizmo render updates asynchronously to reduce UI-thread contention during drag
add/update gizmo manipulation tests for drag updates, pan/orbit filtering, hit-state clearing, and origin separation

Test plan

Not run locally (environment constraints)
Manual: follow README reproduction steps to verify real-time drag redraw and no drift during pan/orbit

Fix for Gizmo drag updates and drift when panning/orbiting Unit tests

github-actions

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6738

Copilot

Pull request overview

This PR addresses gizmo display issues during drag operations and camera navigation (DYN-6738). The fix implements incremental node updates during dragging for real-time redraw, prevents camera pan/orbit events from interfering with gizmo manipulation, and queues render updates asynchronously to reduce UI thread contention.

Changes:

Updated gizmo drag behavior to provide incremental node updates during mouse move and apply final rounding on mouse up
Added filtering in MouseDown/MouseUp to ignore events when camera is panning or orbiting, and added ClearHitState call to prevent drift
Changed render package updates to use asynchronous queuing during drag operations

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
test/DynamoCoreWpf2Tests/ViewExtensions/GizmoManipulationTests.cs	New test file covering drag updates, camera interaction filtering, hit-state clearing, and origin separation
src/DynamoManipulation/TranslationGizmo.cs	Added ClearHitState method to reset cached hit axis and plane
src/DynamoManipulation/NodeManipulator.cs	Updated MouseDown/MouseUp/MouseMove to filter camera events, implement incremental drag updates, and clear hit state

Copilot · 2026-01-21T03:54:36Z

src/DynamoManipulation/NodeManipulator.cs

+                dynamic uiNode = inputNode;
+                uiNode.Value = amount;


The code uses 'dynamic' without type checking, which could fail at runtime if inputNode doesn't have a Value property. Consider adding type validation or using a more specific interface/base type that guarantees the Value property exists.

Copilot · 2026-01-21T03:54:36Z

test/DynamoCoreWpf2Tests/ViewExtensions/GizmoManipulationTests.cs

+            pointNode.IsSelected = true;
+
+            var manipulator = new MousePointManipulator(pointNode, manipulationExtension);
+            var slider = new DoubleSlider { Value = 1.23456 };


The test creates a DoubleSlider but doesn't add it to the graph model or verify it's properly connected. Consider adding the slider to the graph through ExecuteCommand to ensure it's in a valid state, or add a comment explaining why this simplified setup is sufficient for the test.

Copilot · 2026-01-21T03:54:36Z

src/DynamoManipulation/NodeManipulator.cs

+                dynamic uiNode = inputNode;
+                uiNode.Value = Math.Round((double)uiNode.Value, ROUND_UP_PARAM);


The code uses 'dynamic' without type checking, which could fail at runtime if inputNode doesn't have a Value property of type double. Consider adding type validation or using a more specific interface/base type.

Copilot · 2026-01-21T03:54:37Z

test/DynamoCoreWpf2Tests/ViewExtensions/GizmoManipulationTests.cs

+            var updatedNodes = updatedNodesField.GetValue(manipulator) as HashSet<NodeModel>;
+            Assert.IsNotNull(updatedNodes, "inputNodesUpdatedDuringDrag should be a HashSet");
+
+            updatedNodes.Add(slider);


The test modifies internal state through reflection but doesn't verify that the slider node is compatible with the manipulator's expected node types. Consider verifying the node is properly registered with the model or documenting why this direct manipulation is safe for testing.

zeusongit · 2026-01-22T19:25:45Z

src/DynamoManipulation/NodeManipulator.cs

-                    dynamic uiNode = inputNode;
-                    uiNode.Value = Math.Round(amount, ROUND_UP_PARAM);
+                        dynamic uiNode = inputNode;
+                        uiNode.Value = Math.Round(amount, ROUND_UP_PARAM);


maybe a good idea here to check if the final value we are setting for uiNode.Value is not the same or close as the current value?

dynamic uiNode = inputNode; var currentValue = (double)uiNode.Value; var roundedValue = Math.Round(currentValue, ROUND_UP_PARAM); if (Math.Abs(currentValue - roundedValue) > MIN_OFFSET_VAL) { uiNode.Value = roundedValue; }

zeusongit · 2026-01-22T19:34:56Z

src/DynamoManipulation/NodeManipulator.cs

+                uiNode.Value = Math.Round((double)uiNode.Value, ROUND_UP_PARAM);
+            }
+
+            inputNodesUpdatedDuringDrag.Clear();


I think this should also be called in the Dispose() method, since the HashSet contains NodeModel references which will not be cleared in case of early exit from MouseUp event.

aparajit-pratap

@jasonstratton I identified the PR that broke this behavior - #12614 in Dynamo 2.14. This bug is a regression and didn't exist prior to version 2.14. Could you take a look at #12614 and identify reasons why those changes could have caused this regression in the first place?

aparajit-pratap · 2026-01-23T17:40:33Z

src/DynamoManipulation/NodeManipulator.cs

+            // Skip processing if user is panning or orbiting the camera.
+            // This prevents the manipulator from capturing mouse events intended for camera navigation,
+            // including cases where pan/orbit tools use the left mouse button.
+            if (BackgroundPreviewViewModel is DefaultWatch3DViewModel viewModel)


Is this condition to check if the backgroundpreview mode is on and not the graph view mode?

aparajit-pratap · 2026-01-23T19:18:29Z

src/DynamoManipulation/NodeManipulator.cs

+                }
+                else
+                {
+                    var inputNodesToManipulate = InputNodesToUpdateAfterMove(Vector.ByTwoPoints(originBeforeMove, originAfterMove));


When will control reach here inside this else?

aparajit-pratap · 2026-01-23T19:19:27Z

src/DynamoManipulation/NodeManipulator.cs

                }
            }

            //Update gizmo graphics after every camera view change


Will this statement ever be true? If there's a camera view change, it doesn't look to me like control will ever reach here in the first place.

aparajit-pratap · 2026-01-23T19:25:20Z

src/DynamoManipulation/NodeManipulator.cs

+                // This ensures stale axis/plane hit data doesn't affect pan/orbit movements
+                if (gizmo is TranslationGizmo translationGizmo)
+                {
+                    translationGizmo.ClearHitState();


Is this really necessary, even after preventing mouseup or mousedown events from doing anything after a camera change event?

aparajit-pratap · 2026-01-23T19:29:36Z

src/DynamoManipulation/NodeManipulator.cs

            // Doing this triggers a graph update on scheduler thread
            OnGizmoMoved(GizmoInAction, offset);

+            UpdateInputNodesDuringDrag(offset);


Calling this function inside MouseMove seems like the changes in #12614 to improve performance are now being undone since you're now updating the graph for every incremental mouse move event rather than waiting until the mouse button is released.

aparajit-pratap

I wonder if simply preventing camera change events (pan and orbit specifically) from doing any damage in MouseUp will do the trick in fixing this bug. To me, intuitively, it looks like it will.

From what I understand, this bug can be fixed by simply adding this code to the start of MouseDown and MouseUp and calling it a day:

// Skip processing if user is panning or orbiting the camera.
// This prevents the manipulator from capturing mouse events intended for camera navigation,
// including cases where pan/orbit tools use the left mouse button.
if (BackgroundPreviewViewModel is DefaultWatch3DViewModel viewModel)
{
    if (viewModel.IsPanning || viewModel.IsOrbiting)
        return;
}

// Only process left mouse button releases for gizmo manipulation
// Right/middle button releases are for camera navigation (pan/orbit)
if (e.ChangedButton != MouseButton.Left)
{
    return;
}

DYN-6738: Gizmo Display Issues

e71851b

Fix for Gizmo drag updates and drift when panning/orbiting Unit tests

Copilot AI review requested due to automatic review settings January 21, 2026 03:53

github-actions bot reviewed Jan 21, 2026

View reviewed changes

Copilot AI reviewed Jan 21, 2026

View reviewed changes

zeusongit reviewed Jan 22, 2026

View reviewed changes

aparajit-pratap reviewed Jan 23, 2026

View reviewed changes

		dynamic uiNode = inputNode;
		uiNode.Value = Math.Round((double)uiNode.Value, ROUND_UP_PARAM);

DYN-6738: Gizmo Display Issues #16844

Are you sure you want to change the base?

DYN-6738: Gizmo Display Issues #16844

Conversation

jasonstratton commented Jan 21, 2026

Summary

Test plan

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

zeusongit Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

zeusongit Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

aparajit-pratap left a comment

Choose a reason for hiding this comment

Uh oh!

aparajit-pratap Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

aparajit-pratap Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

aparajit-pratap Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aparajit-pratap Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

aparajit-pratap Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

aparajit-pratap left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aparajit-pratap Jan 23, 2026 •

edited

Loading

aparajit-pratap left a comment •

edited

Loading