-
Notifications
You must be signed in to change notification settings - Fork 668
DYN-10073: Fix text wrapping for custom property values in Graph Properties panel #16847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-10073: Fix text wrapping for custom property values in Graph Properties panel #16847
Conversation
Co-authored-by: johnpierson <15744724+johnpierson@users.noreply.github.com>
Co-authored-by: johnpierson <15744724+johnpierson@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses a usability issue in the Graph Properties view extension where long property values would overflow and hide the Edit/Delete buttons. The fix enables text wrapping for property values in the CustomPropertyControl.
Changes:
- Added
TextWrapping="WrapWithOverflow"to the PropertyValue TextBox to enable multi-line display - Added
AcceptsReturn="True"to allow multi-line editing of property values
src/GraphMetadataViewExtension/Controls/CustomPropertyControl.xaml
Outdated
Show resolved
Hide resolved
|
@copilot that did not work. The text box should add new lines as needed and also adjust width based on panel. |
Co-authored-by: johnpierson <15744724+johnpierson@users.noreply.github.com>
Fixed in commit c3c68b4. The issue was that the TextBox needed |
|
Multilines are now working, but it is still flowing past the visible portion @copilot |
Co-authored-by: johnpierson <15744724+johnpierson@users.noreply.github.com>
Fixed in commit 1d13a51. The issue was that the ScrollViewer allowed horizontal scrolling by default, which let content overflow past the visible area. Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10073
|
So, what happens in case of overflow? A vertical scrollbar or horizontal? |
A vertical scrollbar. And if you widen the panel the text will wrap as well. |
Purpose
Fix Graph Properties custom property rows so long values wrap within the panel and action buttons remain visible at narrow widths.
Declarations
Check these if you believe they are true
Release Notes
Fix Graph Properties custom property layout so long values wrap without hiding action buttons.
Reviewers
@DynamoDS/eidos
FYIs
N/A
Before and After:
Fix Graph Properties Long Values Text Wrapping
Plan:
Changes Made:
CustomPropertyControl.xaml:
TextWrapping="WrapWithOverflow"for multi-line text wrappingHorizontalAlignment="Stretch"to ensure TextBox respects panel widthAcceptsReturn="True"(property values should auto-wrap, not allow manual line breaks)GraphMetadataView.xaml:
HorizontalContentAlignmentfrom "Left" to "Stretch" to ensure items fill available widthHorizontalScrollBarVisibility="Disabled"to ScrollViewer to prevent horizontal overflowSolution:
The issue was that the ScrollViewer allowed horizontal scrolling by default, which let content overflow beyond the visible area. By explicitly disabling horizontal scrolling with
HorizontalScrollBarVisibility="Disabled", the content is now constrained to the panel width and wraps properly.Result:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.