Modernize development build & dependencies #30
Conversation
… uneject create-react-app; remove unused dependencies
|
|
||
| ## Deploy to Autodesk (Staging) | ||
|
|
||
| - Confirm that `homepage` in `package.json` is set to `http://staging-dictionary.dynamobim.com/`. The developer may change this address depending on the staging environment. |
There was a problem hiding this comment.
were these docs moved somewhere internal? I think @zeusongit just documented these here.
There was a problem hiding this comment.
Usually it's not a good idea to make staging environments public, so the change makes sense.
| var ml = []; | ||
| ad.forEach(function (d, i) { | ||
| var c = d.Categories; | ||
| var parent = "Home"; |
There was a problem hiding this comment.
could you comment on this change?
There was a problem hiding this comment.
This eliminates an unused variable warning in the development server console.
There was a problem hiding this comment.
Only one minor text issue related to changes here.
Other that that:
-
The "Create Pull Request" functionality hangs for me, but I'm not sure if this ever worked when running local.
-
Another thing I noticed is editing the description of a node does not show up as a change in the "Create Pull Request" dialog. Should it?
-
The unit test is still failing, but it was failing already, so no change there I guess.
|
|
||
| ## Deploy to Autodesk (Staging) | ||
|
|
||
| - Confirm that `homepage` in `package.json` is set to `http://staging-dictionary.dynamobim.com/`. The developer may change this address depending on the staging environment. |
There was a problem hiding this comment.
Usually it's not a good idea to make staging environments public, so the change makes sense.
| <a href="http://dynamoprimer.com/" target="_blank" rel="noopener noreferrer" style={{'color':'orangered'}}>Dynamo Primer</a>, | ||
| this dictionary is open-source - check it out on our | ||
| <a href="https://github.com/DynamoDS/DynamoDictionary" target="_blank" rel="noopener noreferrer" style={{'color':'orangered'}} >Github page</a> | ||
| and contribute!</p> |
There was a problem hiding this comment.
For this part, the text shows next to the link, without spaces separating them:
Fixes a spacing issue between the text and the links in the home page. Also fixes the only unit test, by creating the App component in the same way it's created by the actual application.
|
@Dewb Back to this PR late, would you explain Run npx uneject to restore create-react-app webpack config, reduce direct dependencies? Are we still using webpack here? I am looking at a legacy PR #22 which bring in another webpack package html-loader as dependency and trying to figure out the conflict after this PR and merge that in. Appreciate that.
|
engineproperty in package.jsonnpm auditissuesnpx unejectto restore create-react-app webpack config, reduce direct dependencies