Skip to content

Dynamo Node in depth description, Node help docs steve de witt Round 1#3196

Merged
Mikhinja merged 19 commits intoDynamoDS:masterfrom
stevecbc:NodeHelpDocs-SteveDeWitt
Aug 13, 2025
Merged

Dynamo Node in depth description, Node help docs steve de witt Round 1#3196
Mikhinja merged 19 commits intoDynamoDS:masterfrom
stevecbc:NodeHelpDocs-SteveDeWitt

Conversation

@stevecbc
Copy link
Collaborator

@stevecbc stevecbc commented Jul 2, 2025

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@achintyabhat achintyabhat self-requested a review July 2, 2025 21:12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an accidental file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevecbc This file needs to be removed.

@stevecbc stevecbc changed the title Dynamo Node in depth description, Node help docs steve de witt Dynamo Node in depth description, Node help docs steve de witt Round 1 Jul 23, 2025
@johnpierson johnpierson requested a review from Copilot July 23, 2025 14:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive node help documentation for 27 Dynamo Revit nodes, focusing on wall creation, view management, sheet operations, group handling, family operations, and parameter utilities. The documentation includes both detailed markdown descriptions and working example files to help users understand how to use these nodes effectively.

  • In-depth explanations and usage examples for wall, view, and sheet creation nodes
  • Documentation for group management, family operations, and parameter utilities
  • Working .dyn example files demonstrating practical node usage

Reviewed Changes

Copilot reviewed 46 out of 70 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
Revit.Elements.Wall.ByCurveAndLevels.md Adds wall creation documentation with level constraints
Revit.Elements.Views.*.md (8 files) Documents view operations including crop box, section views, and schedule filters
Revit.Elements.Views.Sheet.*.md (6 files) Comprehensive sheet creation and duplication documentation
Revit.Elements.Group.*.md (4 files) Group creation, placement, and attachment documentation
Revit.Elements.FamilyType.*.md (2 files) Family creation from geometry documentation
Revit.Elements.FamilyInstance.*.md (5 files) Family instance placement documentation
Revit.Elements.Element.GetChildElements.md Child element retrieval documentation
Revit.Elements.Parameter.Unit.md Parameter unit type documentation
*.dyn files (13 files) Working example files for documented nodes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevecbc Group needs a title

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevecbc Image is zoomed out and not clear to read. Suggest using Watch3D node to show the geometry, that way can zoom in on the graph for better visibility.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevecbc Image is zoomed out and not clear to read. Suggest using Watch3D node to show the geometry, that way can zoom in on the graph for better visibility.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevecbc Monocle icons are seen in the image, can you please fix the image as it is not available OOTB and can confuse users.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevecbc Group needs a title

Copy link

@achintyabhat achintyabhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevecbc Overall looks good, just a few minor things here and there! Can you please make the minor changes to description and images as requested in the comments here.

stevecbc and others added 14 commits August 8, 2025 09:17
….dyn

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…iew.ClearAllFilters.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ameNumberTitleBlock.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ameNumberTitleBlockViewAndLocation.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ameNumberTitleBlockViewsAndLocations.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ropBox.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevecbc This image has been cut-off on the right side.

Copy link

@achintyabhat achintyabhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One image needs to be updated.

Copy link

@achintyabhat achintyabhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@Mikhinja Mikhinja merged commit c2a8dfd into DynamoDS:master Aug 13, 2025
9 of 10 checks passed
@ZbynekHanak-RWS
Copy link
Collaborator

Hi @Mikhinja, seems the en-US .md files were posted in [https://github.com/DynamoDS/DynamoRevit/tree/master/doc/distrib/NodeHelpFiles/en-US] instead of [https://github.com/DynamoDS/DynamoRevit/tree/master/doc/distrib/NodeHelpFiles/en-US/fallback_docs] folder like the rest of NodeHelpFiles sources for localization. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants