Skip to content

Conversation

@Mikhinja
Copy link
Collaborator

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates DynamoRevit to support .NET 10 by adding build configurations and updating dependency versions. The changes prepare the codebase for migration from .NET 8.0 to .NET 10.0 while maintaining backward compatibility.

  • Adds NET100 platform configurations alongside existing NET80 configurations
  • Updates Dynamo core package references from version 3.6.1.9895 to 4.0.0-beta2630
  • Modifies build scripts to use dynamic library subfolder references

Reviewed Changes

Copilot reviewed 5 out of 893 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/DynamoRevit/DynamoRevit.csproj Updates copy targets to use dynamic library path variables
src/DynamoRevit.All.sln Adds NET100 Debug and Release configurations for all projects
src/Config/packages_versions.props Updates DYNAMOCORE_VERSION to 4.0.0-beta2630
src/Config/packages.aget Updates all Dynamo package references to 4.0.0-beta2630
src/Config/CS_SDK.props Adds NET100 platform support with net10.0-windows target framework

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

<TargetFramework Condition="'$(Platform)' == 'NET80'">net8.0-windows</TargetFramework>
<TargetFramework Condition="'$(Platform)' == 'NET100'">net10.0-windows</TargetFramework>
<DCoreLibSubFolder Condition="'$(Platform)' == 'NET80'">net8.0</DCoreLibSubFolder>
<DCoreLibSubFolder Condition="'$(Platform)' == 'NET100'">net8.0</DCoreLibSubFolder>
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DCoreLibSubFolder for NET100 platform should be 'net10.0' not 'net8.0' to match the target framework being used for .NET 10.

Suggested change
<DCoreLibSubFolder Condition="'$(Platform)' == 'NET100'">net8.0</DCoreLibSubFolder>
<DCoreLibSubFolder Condition="'$(Platform)' == 'NET100'">net10.0</DCoreLibSubFolder>

Copilot uses AI. Check for mistakes.
* update GregRevitAuth
* move some dependencies from aget to nuget method
@Mikhinja Mikhinja marked this pull request as ready for review October 2, 2025 09:20
@Mikhinja Mikhinja merged commit 6c16877 into master Oct 2, 2025
2 of 4 checks passed
@Mikhinja Mikhinja deleted the feature/dotnet10 branch October 2, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants