i#5383: Fix macOS arm64 test build/run#7171
Merged
edeiana merged 10 commits intoDynamoRIO:masterfrom Feb 28, 2025
Merged
Conversation
- Disable selfmod tests due to build failures on M3 - Fix macOS build for mangle_pauth test (test still fails for some reason) - Mark dump_ucontext as NYI on macOS - Fixes NULL sigcontext_t in os_forge_exception - Adds -vm_size 500M to client tests to avoid reachablity assert
Contributor
Author
|
only a64 failure is raw-zlib #5635, doesn't seem to be my fault |
ndrewh
changed the title
edeiana
pushed a commit
that referenced
this pull request
Jan 16, 2025
This fixes several build and runtime issues under macOS on ARM64 on macOS 14.4.1 (Sonoma). - `FEATURE_PAUTH` is now detected on macOS using a sysctl (capability MSRs cannot be read in userspace on M3 at least). - In the preload library and os.c, `_init` needs `__attribute__((constructor))` to be run by dyld. - `PLATFORM_SUPPORTS_SCATTER_GATHER` is broken, disabled for now on a64 macOS. - Fixed sigcontext/mcontext conversion which assumes old `simd` size and was failing on an assert. Known issues that remain: - VM allocation frequently but nondeterministically fails reachability constraints. `-vm_size 500M` seems to fix this. #7171 adds this flag to tests on macOS+ARM64. Another option is to make this the default on macOS+ARM64. - Sometimes some bookkeeping asserts in `vmh_exit` are reached upon process exit. The end result is that the `bbcount` tool works on a simple toy program on macOS, in debug mode, without hitting any asserts: ``` bin64/drrun -debug -vm_size 500M -c api/bin/libbbcount.dylib -- ./main ``` Issue #5383
edeiana
reviewed
Feb 25, 2025
Contributor
There was a problem hiding this comment.
Thank you for filing #7296 , please add it to the PR description along with #5383.
Have a look at #7296 (comment). The rest LGTM.
edeiana
approved these changes
Feb 28, 2025
Contributor
edeiana
left a comment
edeiana
left a comment
There was a problem hiding this comment.
LGTM, thank you for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes tests build and run properly on macOS (14.4) arm64 (M3). Many tests do not pass, but you can at least run them now.
reachable_clientoption by default on macOSIssue #5383
Issue #7296