Skip to content

i#7132: Disable instr_length DEBUG_ASSERT on 32-bit ARM. #7184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
egrimley-arm merged 1 commit into from
Jan 13, 2025
Merged

i#7132: Disable instr_length DEBUG_ASSERT on 32-bit ARM. #7184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions clients/drcachesim/tracer/raw2trace.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2666,7 +2666,11 @@ instr_summary_t::construct(void *dcontext, app_pc block_start, DR_PARAM_INOUT ap
}
DEBUG_ASSERT(*pc > desc->pc_);
desc->length_ = static_cast<byte>(*pc - desc->pc_);
// FIXME i#4016: On ARM calling instr_length causes the instruction to be
// reencoded and that can change the length of a T32 instr from 4 to 2.
#ifndef ARM
DEBUG_ASSERT(*pc - desc->pc_ == instr_length(dcontext, instr));
#endif

desc->packed_ = 0;

Expand Down
Loading