i#2154 Android64: Conditionally compile get_kernel_args()#7240
Merged
jackgallagher-arm merged 5 commits intomasterfrom Feb 5, 2025
Merged
i#2154 Android64: Conditionally compile get_kernel_args()#7240jackgallagher-arm merged 5 commits intomasterfrom
jackgallagher-arm merged 5 commits intomasterfrom
Conversation
Since the original 32-bit Android port was done bionic was changed [1] to pass argc, argv, and envp to library _init() functions so we can get rid of the old workaround. This fixes several tests which were failing with the error: ``` Internal Error: DynamoRIO debug check failure: failed to find envp @dynamorio/core/unix/os.c:801 envp != NULL ``` [1] https://android.googlesource.com/platform/bionic/+/554374693408cd7c74d0cae596fca7349661edea Issue: #2154
derekbruening
approved these changes
Jan 31, 2025
This reverts commit f06b6a7.
Change-Id: I5b06d4ca28369d1507d7b8fccc77bba3cffa4d5d
jackgallagher-arm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the original 32-bit Android port was done bionic was changed [1] to pass argc, argv, and envp to library _init() functions so when targeting newer versions of Android (>= 8.0, API level 26) we don't need the old workaround.
This fixes several tests which were failing with the error:
[1] https://android.googlesource.com/platform/bionic/+/554374693408cd7c74d0cae596fca7349661edea
Issue: #2154