i#3544: RV64: Support RISC-V ELF in module_get_platform()#7247
Merged
ziyao233 merged 4 commits intoDynamoRIO:masterfrom Feb 6, 2025
Merged
i#3544: RV64: Support RISC-V ELF in module_get_platform()#7247ziyao233 merged 4 commits intoDynamoRIO:masterfrom
ziyao233 merged 4 commits intoDynamoRIO:masterfrom
Conversation
Differing from x86 and ARM, 32-bit and 64-bit variants of RISC-V share the same e_machine constant EM_RISCV, thus additional check against e_ident is required to obtain the bitwidth. This fixes test linux.execve-null on riscv64, where DynamoRIO wrongly assumes an execve call to a RISC-V ELF will fail, thus loses control of the child process. Issue: DynamoRIO#3544
ksco
approved these changes
Feb 6, 2025
derekbruening
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differing from x86 and ARM, 32-bit and 64-bit variants of RISC-V share the same e_machine constant EM_RISCV, thus additional check against e_ident is required to obtain the bitwidth.
This fixes test linux.execve-null on riscv64, where DynamoRIO wrongly assumes an execve call to a RISC-V ELF will fail, thus loses control of the child process. The test fails on QEMU so isn't enabled in CI for now.
Issue: #3544