i#2154 Android64: Simplify build and add GitHub CI workflow#7248
Merged
derekbruening merged 1 commit intomasterfrom Feb 6, 2025
Merged
i#2154 Android64: Simplify build and add GitHub CI workflow#7248derekbruening merged 1 commit intomasterfrom
derekbruening merged 1 commit intomasterfrom
Conversation
derekbruening
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a job to the GitHub CI that builds DynamoRIO for AArch64 Android.
This patch also simplifies the 64-bit Android CMake file to remove the need for the user to build
zlib, instead allowing CMake to find thezlibincluded in the NDK. Also, the user now only needs to pass the root folder of the NDK, and a bug relating to the default Android API level has been fixed.The Android CMake files have also been renamed to better reflect their differences - i.e. they are now named
gcc&llvmrather thanandroidandandroid-aarch64.Issue: #2154