i#7157: Inject syscall templates dynamically in scheduler#7277
Merged
abhinav92003 merged 21 commits intomasterfrom Feb 27, 2025
Merged
i#7157: Inject syscall templates dynamically in scheduler#7277abhinav92003 merged 21 commits intomasterfrom
abhinav92003 merged 21 commits intomasterfrom
Conversation
Adds support to the drmemtrace scheduler for injecting system call trace templates dynamically during scheduling. This obviates the need to create a separate statically-injected trace with system call trace templates. Reuses context switch trace injection code to the extent possible. Adds a new analyzer flag -sched_syscall_file and new scheduler_options_t fields to allow specifying the system call trace template file. Issue: #7157
abhinav92003
commented
Feb 14, 2025
derekbruening
approved these changes
Feb 14, 2025
derekbruening
approved these changes
Feb 18, 2025
Contributor
Author
|
Some corner cases wrt ordinal tracking that I initially thought would affect syscall injection and tried to fix in #7299 seem like they don't really affect this PR. So I'm going to go ahead with submitting this. |
Contributor
Author
|
It will be nicer if the added tests verify schedule_stats output for a new scheduler stat for syscall injection count. But since this PR is already too big I'm going to split it to a follow up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to the drmemtrace scheduler for injecting system call trace templates dynamically during scheduling. This obviates the need to create a separate statically-injected trace with system call trace templates.
Reuses context switch trace injection code to the extent possible.
Adds a new analyzer flag -sched_syscall_file and new scheduler_options_t fields to allow specifying the system call trace template file.
Adds a mock system call template file generated using the burst_syscall_inject test (slightly modified to use sysnums that match the checked-in test trace).
Adds various unit tests: a new scheduler unit test that verifies dynamic syscall trace injection and its effect on scheduling, analyzer tests that use -sched_syscall_file for dynamic injection in core-sharded and non-core-sharded modes, and an invariant checker test on the added mock system call template file.
Issue: #7157