i#4915: label non-fetched instructions in drmemtrace view tool#7810
Merged
GandholiSarat merged 3 commits intomasterfrom Feb 12, 2026
Merged
i#4915: label non-fetched instructions in drmemtrace view tool#7810GandholiSarat merged 3 commits intomasterfrom
GandholiSarat merged 3 commits intomasterfrom
Conversation
Instruction records with type TRACE_TYPE_INSTR_NO_FETCH were previously displayed as normal ifetch entries in the drmemtrace view tool when decoding was enabled, which was misleading for REP string expansion. This change updates the view tool output to label such records as non-fetched, without altering trace generation or expansion logic. Xref i#4915.
Add an x86-only subtest in view_test.cpp to verify that TRACE_TYPE_INSTR_NO_FETCH records are labeled as "non-fetched" in the drmemtrace view tool output. Xref #4915.
Member
Author
|
I’ve added an x86-only test in This is my first time adding a test in this part of the drmemtrace suite, so please let me know if you’d prefer any adjustments to structure or style. |
derekbruening
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instruction records with type TRACE_TYPE_INSTR_NO_FETCH were previously displayed as normal ifetch entries in the drmemtrace view tool when decoding was enabled, which was misleading for REP string expansion.
This change updates the view tool output to label such records as non-fetched, without altering trace generation or expansion logic.
Xref #4915.