Skip to content

i#7447: Fix ninja rebuild problem #7834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derekbruening merged 1 commit into from
Mar 10, 2026
+4 −3
Merged

i#7447: Fix ninja rebuild problem #7834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions make/utils.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# **********************************************************
# Copyright (c) 2012-2025 Google, Inc. All rights reserved.
# Copyright (c) 2012-2026 Google, Inc. All rights reserved.
# **********************************************************
#
# Redistribution and use in source and binary forms, with or without
Expand Down Expand Up @@ -273,8 +273,9 @@ if (UNIX)
set_directory_properties(PROPERTIES
ADDITIONAL_MAKE_CLEAN_FILES "${ld_script}")
set(ldflags "-Wl,${ld_script_option},\"${ld_script}\"")
add_custom_command(TARGET ${target}
PRE_LINK
add_custom_target(${target}_ldscript DEPENDS ${ld_script})
add_dependencies(${target} ${target}_ldscript)
add_custom_command(OUTPUT ${ld_script}
COMMAND ${CMAKE_COMMAND}
# script does not inherit any vars so we must pass them all in
# to work around i#84 be sure to put a space after -D for 1st arg at least
Expand Down
Loading