Skip to content

Only use JSON-native types with sidekiq #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adamruzicka wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −3
Draft

Only use JSON-native types with sidekiq #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1231369
Only use JSON-native types with sidekiq
adamruzicka Nov 18, 2025
a043bca
Dump and load during serialization
adamruzicka Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/dynflow/executors/sidekiq/core.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
config[:semi_reliable_fetch] = true
Sidekiq::ReliableFetch.setup_reliable_fetch!(config)
end
::Sidekiq.strict_args!(false)
::Sidekiq.strict_args!

module Dynflow
module Executors
Expand Down
3 changes: 2 additions & 1 deletion lib/dynflow/executors/sidekiq/serialization.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module Sidekiq
# Module to prepend the Sidekiq job to handle the serialization
module Serialization
def self.serialize(value)
Dynflow.serializer.dump(value)
JSON.parse(JSON.dump(Dynflow.serializer.dump(value)))
end

def self.deserialize(value)
Expand All @@ -18,6 +18,7 @@ module WorkerExtension
# Overriding the Sidekiq entry method to perform additional serialization preparation
module ClassMethods
def client_push(opts)
opts = Utils::IndifferentHash.new(opts)
opts['args'] = opts['args'].map { |a| Serialization.serialize(a) }
super(opts)
end
Expand Down
8 changes: 7 additions & 1 deletion lib/dynflow/serializer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ def dump(object, options = {})
case object
when ::Array
object.collect { |v| dump(v) }
when ::Symbol
generate_other(object)
else
super
end
Expand All @@ -38,7 +40,9 @@ def parse_other(other, options = {})
end

if (type_name = other[ARBITRARY_TYPE_KEY] || other[ARBITRARY_TYPE_KEY.to_s])
if type_name == 'Time' && (time_str = other['value'])
if type_name == 'Symbol' && (val_str = other['value'])
return val_str.to_sym
elsif type_name == 'Time' && (time_str = other['value'])
return Serializable.send(:string_to_time, time_str)
end
type = Utils.constantize(type_name) rescue nil
Expand All @@ -53,6 +57,8 @@ def parse_other(other, options = {})

def generate_other(object, options = {})
hash = case
when object.is_a?(Symbol)
{ ARBITRARY_TYPE_KEY => 'Symbol', 'value' => object.to_s }
when object.respond_to?(:to_h)
object.to_h
when object.respond_to?(:to_hash)
Expand Down