Final Task - Aleksandra Khorosheva#173
Open
a-khorosheva wants to merge 4 commits intoE-P-T:masterfrom
Open
Conversation
Parse all required arguments and store in the custom object Params Create parser hierarchy and implement parsing rss from URL Sort and apply limits to rss feed Create processors hierarchy and implement both plain text printer and json printer For verbose mode create message consumer abstraction Wrap main method with try except not to give exceptions for final user
Write dependencies in setup.py Make requirements.txt fetch dependencies from setup.py
Implement mapper from and to json Implement local caching. Store cache in temporary file in json format
Make html conversion with the plain strings (build html by hand) Make pdf conversion with the help of fpdf library. It requires a font that supports unicode. Add OpenSans.ttf to the project and create a task in setup.py to copy it to a library folder (it is the only consistent way to be able to run the program from any folder on the system) Write unit and integration tests for crucial parts of application (using pytest and mocks) Move sorting, cache and limit to preprocessing Write documentation for caching and testing Update requirements Fix all FIXME and TODOs Reformat the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four iterations done