-
Notifications
You must be signed in to change notification settings - Fork 456
Update testing for configurations with active Greenland ice sheet #7892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update testing for configurations with active Greenland ice sheet #7892
Conversation
Swap out low-res 20km mesh with var. res. 4-to-40km mesh; generalize shell commands and namelist file changes (not specific to a single mesh resolution); exclude regional stats generation for MALI (which prohibits comparison between multiple MALI hist. files); add ERS test for BG config.
Add reg exp matching to cime archiving script to pull in wider range of MPAS hist files in testing; Correct pe layouts for Chrys and PM testing.
Updated pes support for testing on Chrys and PM-cpu; reduce no. of days for ERS tests; remove no longer needed test mod support (due to default timestepping setting changes); rename test mod dir names; update default pe layouts for IG cases
matthewhoffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephenprice , thanks for tackling this longstanding cleanup work. I have a handful of questions/comments. Some are in files I'm not super familiar with, so in some cases I'm guessing a little bit. I've reviewed by inspection but haven't tried running any tests with the branch.
| <hist_file_ext_regex>\w+</hist_file_ext_regex> | ||
| <hist_file_ext_regex>\w+\.\w+</hist_file_ext_regex> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert in regex or familiar with how this file works, but I wonder if there is a more specific search we can employ or if both versions are necessary. Maybe not. @jonbob , do you have experience with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I was told a while back was that this should work but that there is some CIME bug preventing it from fully working. For the moment, it at least works to generate hist file baselines for MALI, which can then be later compared against newly generated baselines. It still does not work for including MALI hist files in a restart comparison unfortunately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephenprice -- it doesn't include MALI hist files in an ERS test? Or not MALI restart files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few diff. issues here. First, those lines of code are supposed to allow both mali .hist and .am files to be compared against a set of baseline files. As discussed here though (in section titled "Notes from Jason Boutte..."). In my experimenting however, this does not work and only the .am files get compared. This is why I've set the user_nl_mali to exclude .am files from outputs for these tests. But I figure it does not hurt to include that functionality for if / when this problem gets attention and gets fixed (currently, we would at least be comparing newly generated mali .hist files to baselines during SMS testing).
It's possible that this is by design, but from what I can tell, in my ERS tests nothing gets compared aside from coupler history files. It would be nice if mpas component hist files were also compared. I think this is considered not necessary because the mpas components generate and pass fields that populate the cpl hist files. But right now, we pass very little to the cpl, and for short runs, most of those fields are going to contain all zeroes, which does not feel like a very rigorous restart test (for mali at least). It's unclear to me why hist files from other components, including mpas components, are not included in the comparison for ERS tests. Should they be?
| <ntasks_rof>64</ntasks_rof> | ||
| <ntasks_ice>64</ntasks_ice> | ||
| <ntasks_ocn>64</ntasks_ocn> | ||
| <ntasks_glc>960</ntasks_glc> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as previous comment about danger of having one component with so many more tasks than any other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See response to above comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revisit this test and see how it performs w/ a smaller set of pes (e.g., 256 or 512).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
components/mpas-albany-landice/cime_config/testdefs/testmods_dirs/mali/gis/user_nl_mali
Outdated
Show resolved
Hide resolved
…tions Remove redundant 'gis' testmods dir under MALI component subdir; change pe layouts for testing to use 512 vs 256 pes; update description of default pe layout for IG case tests; update 'extra snowlayers' test to use 4-to-40km Greenland grid rather than no-longer-supported 20km grid
matthewhoffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving as Steve has addressed all my comments. @jonbob , there still is the thread about history file comparisons in tests that I'm not totally sure if we came to a full understanding of. But the current changes seem to yield the desired behavior, so I'm happy to sign off on it despite not understanding the issues. I'm flagging that in case you want to look at that element more closely.
|
@jonbob -- I also confirmed that, when running the full landice test suite while using '--pesfile' to point to the correct 'config_pes_tests.xml' file, the behavior is as expected w.r.t. nodes used for the different tests in the suite (confirmed only on Chrys for now since pm-cpu is down today). |
trhille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
landice_developer tests pass on Chrysalis.
| <grid name="a%ne30np4.pg2_l%r05_oi%null_r%r05_g%mpas.gis4to40km_w%null_z%null_m%IcoswISC30E3r5"> | ||
| <mach name="pm-cpu|muller-cpu|alvarez-cpu"> | ||
| <pes compset="any" pesize="any"> | ||
| <comment>pm-cpu: IG-case testing config. using 4-to-40km (mde res) GIS init. cond.</comment> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <comment>pm-cpu: IG-case testing config. using 4-to-40km (mde res) GIS init. cond.</comment> | |
| <comment>pm-cpu: IG-case testing config. using 4-to-40km (med res) GIS init. cond.</comment> |
(I think this is what you meant)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Good catch. I'll fix that typo and push it up.
|
@jonbob is this ready? |
|
@rljacob -- I think so. I'll test it today and merge |
…to40km-grid' into next (PR #7892) Update testing for configurations with active Greenland ice sheet Update existing testing support for IG and BG cases that uses 20km, uniform resolution Greenland mesh, to use newer variable resolution 4-to-40km mesh. All existing and new landice developer tests have been confirmed to pass. Changes to mali section of cime_config/config_archive.xml should now allow mali hist files to be compared against a baseline (prev. support used a hist.am file for this). A follow-up PR will fully remove support for Greenland 20km mesh [BFB] for all current tests, but does change landice tests
|
passes:
merged to next |
|
merged to master and expected NML and regular DIFFs (due to new baselines) blessed, except for pm-cpu which has not reported |
|
expected NML and regular DIFFs (due to new baselines) also blessed on pm-cpu |
Update existing testing support for IG and BG cases that uses 20km, uniform resolution Greenland mesh, to use newer variable resolution 4-to-40km mesh. All existing and new landice developer tests have been confirmed to pass. Changes to mali section of ./cime_config/config_archive.xml should now allow mali hist files to be compared against a baseline (prev. support used a hist.am file for this). A follow-up PR will fully remove support for Greenland 20km mesh (draft PR 7898).
[NML]
[BFB] for all current tests, but does change landice tests