No changes needed - validate_eps is correct as-is #8000
Closed
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7999 received a bot review suggesting to relax
validate_epsfrom1e-12to1e-9or1e-6in the variance scaling test. After analysis, this change is unnecessary.Decision: No changes required
The current implementation correctly uses two thresholds with distinct purposes:
detect_eps = 1e-3: Determines if variance scaling is active (ratio differs from 1.0)validate_eps = 1e-12: Detects physical violations (rate suppression, ratio < 1.0)The strict
1e-12tolerance is appropriate because:This PR documents the decision to keep the existing implementation.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.