Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 17, 2026

PR #7999 received a bot review suggesting to relax validate_eps from 1e-12 to 1e-9 or 1e-6 in the variance scaling test. After analysis, this change is unnecessary.

Decision: No changes required

The current implementation correctly uses two thresholds with distinct purposes:

  • detect_eps = 1e-3: Determines if variance scaling is active (ratio differs from 1.0)
  • validate_eps = 1e-12: Detects physical violations (rate suppression, ratio < 1.0)

The strict 1e-12 tolerance is appropriate because:

  1. It distinguishes "feature inactive" (ratio ≈ 1.0) from "feature broken" (ratio < 1.0)
  2. Changing it creates commit noise without altering test behavior
  3. The two-threshold design already handles numerical precision correctly

This PR documents the decision to keep the existing implementation.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] WIP address feedback on P3 autoconversion tests No changes needed - validate_eps is correct as-is Jan 17, 2026
Copilot AI requested a review from pressel January 17, 2026 16:10
@pressel pressel closed this Jan 17, 2026
@pressel pressel deleted the copilot/sub-pr-7999 branch January 17, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants