Skip to content

fix ctest MPI mpirun arguments#340

Merged
mark-petersen merged 1 commit intoE3SM-Project:developfrom
tukss:omega/fix-mpirun-args
Feb 17, 2026
Merged

fix ctest MPI mpirun arguments#340
mark-petersen merged 1 commit intoE3SM-Project:developfrom
tukss:omega/fix-mpirun-args

Conversation

@tukss
Copy link

@tukss tukss commented Feb 10, 2026

Some MPI implementations do not like -n 8 as a single argument to mpirun. Splitting it into two is more portable.

The CTest tests pass locally on my laptop but I haven't run any part of the test suite on a different machine.

Fixes #339.

Checklist

  • Linting
  • Building
    • CMake build does not produce any new warnings from changes in this PR
  • Testing
    • Add a comment to the PR titled Testing with the following:
      • Which machines CTest unit tests
        have been run on and indicate that are all passing.
      • The Polaris omega_pr test suite
        has passed, using the Polaris e3sm_submodules/Omega baseline
      • Document machine(s), compiler(s), and the build path(s) used for -p for both the baseline (Polaris e3sm_submodules/Omega) and the PR build
      • Indicate "All tests passed" or document failing tests
      • Document testing used to verify the changes including any tests that are added/modified/impacted.
      • Performance related PRs: Please include a relevant PACE experiment link documenting performance before and after.

Some MPI implementations do not like `-n 8` as a single argument to mpirun. Splitting
it into two is more portable.

Fixes E3SM-Project#339.
Copy link
Member

@mwarusz mwarusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the linked issue says, most tests already use this pattern. Approve by inspection.

Copy link

@grnydawn grnydawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also support this approach.

@mark-petersen mark-petersen self-assigned this Feb 17, 2026
@mark-petersen mark-petersen merged commit eccad5c into E3SM-Project:develop Feb 17, 2026
7 checks passed
@tukss tukss deleted the omega/fix-mpirun-args branch February 19, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merged arguments to mpirun prevent execution of some tests

4 participants