Move all spack templates to their own subdirectory#251
Merged
xylar merged 4 commits intoE3SM-Project:mainfrom Apr 14, 2025
Merged
Move all spack templates to their own subdirectory#251xylar merged 4 commits intoE3SM-Project:mainfrom
xylar merged 4 commits intoE3SM-Project:mainfrom
Conversation
Collaborator
Author
TestingI tested these changes by doing a test deployment of Polaris using this branch. Everything appears to have worked as expected. I didn't take a look at the documentation because I don't expect any issues there, but I can do so if desired. |
xylar
reviewed
Apr 14, 2025
Comment on lines
+3
to
+6
| include mache/spack/templates/*.yaml | ||
| include mache/spack/templates/*.template | ||
| include mache/spack/templates/*.sh | ||
| include mache/spack/templates/*.csh |
Collaborator
There was a problem hiding this comment.
Thanks for catching that one! It wouldn't otherwise show up until we do a release and build a conda package, since the files are just there in the branch when you do local testing.
xylar
approved these changes
Apr 14, 2025
Collaborator
xylar
left a comment
xylar
left a comment
There was a problem hiding this comment.
This looks great! I appreciate you doing the hard work of testing this, @altheaden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relocates the templates in the
mache/spackdirectory to a subdirectory,mache/spack/templates. This modularization is ultimately in preparation for merging #230.Checklist
api.md) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changes