Translate linear EOS between MPAS-Ocean and Omega#458
Open
cbegeman wants to merge 6 commits intoE3SM-Project:mainfrom
Open
Translate linear EOS between MPAS-Ocean and Omega#458cbegeman wants to merge 6 commits intoE3SM-Project:mainfrom
cbegeman wants to merge 6 commits intoE3SM-Project:mainfrom
Conversation
Collaborator
Author
Testing:For Output for |
Collaborator
|
@cbegeman, let's chat about this one at our meeting today. My feeling would be that we should aim to make this PR have bit-for-bit changes unless there is a strong reason not to. That would mean that the new default values would be: # Equation of state -drho/dT, defaults to mpas-ocean default
eos_linear_alpha = 0.2
# Equation of state drho/dS, defaults to mpas-ocean default
eos_linear_beta = 0.8
# Equation of state constant term, designed to match mpas-ocean's default linear EOS
# 1000.0 + 0.2 * 5.0 - 0.8 * 35 = 973.0
eos_linear_rhoref = 973.0
# Equation of state reference temperature, defaults to zero because omega doesn't have this term
eos_linear_Tref = 0.0
# Equation of state reference salinity, defaults to zero because omega doesn't have this term
eos_linear_Sref = 0.0Then, I would think we would want to update the ocean:
eos:
config_eos_type: linear
eos_linear:
config_eos_linear_alpha: 0.2
config_eos_linear_beta: 0.01
# 1000.0 + 0.2 * 5 - 0.01 * 35
eos_linear_rhoref: 1000.65It's okay if this PR is meant to be non-bit-for-bit but I think we want to document that more clearly if so. |
cbegeman
commented
Feb 3, 2026
cbegeman
commented
Feb 3, 2026
Collaborator
Author
|
@xylar Those are good suggestions. I committed them and will test for BFB-ness |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #406
Checklist
Testingcomment in the PR documents testing used to verify the changes