Skip to content

Add pseudothickness to write_model_dataset for Omega#460

Draft
cbegeman wants to merge 10 commits intoE3SM-Project:mainfrom
cbegeman:omega/add-pseudothickness-to-write-model-dataset
Draft

Add pseudothickness to write_model_dataset for Omega#460
cbegeman wants to merge 10 commits intoE3SM-Project:mainfrom
cbegeman:omega/add-pseudothickness-to-write-model-dataset

Conversation

@cbegeman
Copy link
Collaborator

@cbegeman cbegeman commented Feb 3, 2026

Add the pseudo-thickness to model datasets for Omega initial conditions.

Surface pressure (constant value from config file), temperature, salinity and layer thickness are used to compute the pressure at layer interfaces. One iteration is currently used, pending testing of how many iterations is needed for convergence to desired accuracy.

The pressure at interfaces and a reference density (from config file) are then used to compute the pseudo-thickness.

The pseudo-thickness is automatically added to any write_model_dataset call when Omega is the ocean model AND the optional config argument is provided. (Note: checks for presence of config argument are still needed)

Fixes #461

Depends on #440 for routines related to computing p_interface from model dataset.

Depends on E3SM-Project/Omega#327 to rename LayerThickness to PseudoThickness
OR we can map variable name PseudoThickness (added to MPAS-O dataset before variable mapping) to LayerThickness

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

@cbegeman
Copy link
Collaborator Author

cbegeman commented Feb 3, 2026

Testing

Only the manufactured_solution/convergence_both/default case has been run on chrys with intel with this feature. I also ran cosine_bell/restart through init to make sure that the absence of config argument caused pass-through.

@cbegeman cbegeman force-pushed the omega/add-pseudothickness-to-write-model-dataset branch from cd69ef2 to 2f9231f Compare February 3, 2026 19:02
@cbegeman cbegeman self-assigned this Feb 3, 2026
@cbegeman cbegeman added bug Something isn't working Omega PR required The polaris changes won't work with the current Omega submodule and require an update framework Changes relating to the polaris framework as opposed to individual tests or analysis ocean Related to the ocean component labels Feb 3, 2026
[vertical_grid]

# The initial surface pressure when not spatially-varying in Pascals
surface_pressure = 1.e5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be zero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working framework Changes relating to the polaris framework as opposed to individual tests or analysis ocean Related to the ocean component Omega PR required The polaris changes won't work with the current Omega submodule and require an update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Omega requires PseudoThickness in initial state file

2 participants

Comments