Add pseudothickness to write_model_dataset for Omega#460
Draft
cbegeman wants to merge 10 commits intoE3SM-Project:mainfrom
Draft
Add pseudothickness to write_model_dataset for Omega#460cbegeman wants to merge 10 commits intoE3SM-Project:mainfrom
cbegeman wants to merge 10 commits intoE3SM-Project:mainfrom
Conversation
Collaborator
Author
TestingOnly the |
cd69ef2 to
2f9231f
Compare
11 tasks
xylar
reviewed
Feb 16, 2026
polaris/ocean/ocean.cfg
Outdated
| [vertical_grid] | ||
|
|
||
| # The initial surface pressure when not spatially-varying in Pascals | ||
| surface_pressure = 1.e5 |
Collaborator
There was a problem hiding this comment.
I think this should be zero
cbegeman
commented
Feb 16, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the pseudo-thickness to model datasets for Omega initial conditions.
Surface pressure (constant value from config file), temperature, salinity and layer thickness are used to compute the pressure at layer interfaces. One iteration is currently used, pending testing of how many iterations is needed for convergence to desired accuracy.
The pressure at interfaces and a reference density (from config file) are then used to compute the pseudo-thickness.
The pseudo-thickness is automatically added to any
write_model_datasetcall when Omega is the ocean model AND the optional config argument is provided. (Note: checks for presence of config argument are still needed)Fixes #461
Depends on #440 for routines related to computing
p_interfacefrom model dataset.Depends on E3SM-Project/Omega#327 to rename
LayerThicknesstoPseudoThicknessOR we can map variable name
PseudoThickness(added to MPAS-O dataset before variable mapping) toLayerThicknessChecklist
api.md) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changes