Skip to content

Fix legacy 3.1.0 www paths#801

Merged
forsyth2 merged 1 commit intomainfrom
fix-legacy-310-tests
Mar 31, 2026
Merged

Fix legacy 3.1.0 www paths#801
forsyth2 merged 1 commit intomainfrom
fix-legacy-310-tests

Conversation

@forsyth2
Copy link
Copy Markdown
Collaborator

@forsyth2 forsyth2 commented Mar 27, 2026

Summary

Objectives:

  • Fix the www path for the legacy-3.1.0 tests to avoid over-writing of results from the non-legacy tests.

Issue resolution:

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

Small Change

  • To merge, I will use "Squash and merge". That is, this change should be a single commit.
  • Logic: I have visually inspected the entire pull request myself.
  • Pre-commit checks: All the pre-commits checks have passed.

@forsyth2 forsyth2 self-assigned this Mar 27, 2026
@forsyth2 forsyth2 added semver: bug Bug fix (will increment patch version) Testing Files in `tests` modified labels Mar 27, 2026
@forsyth2 forsyth2 marked this pull request as ready for review March 31, 2026 17:18
Copy link
Copy Markdown
Collaborator Author

@forsyth2 forsyth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was tested as part of the 3/27 main branch test, so I think it should be good to merge.

However, I expect the auto-generated files will have merge conflicts with #788, so I'm going to merge that first and then address any such conflicts here. (#800, if/when we get to it, would remove any need to worry about conflicts in the auto-generated files).

@forsyth2 forsyth2 force-pushed the fix-legacy-310-tests branch from 1416d96 to 3ecc725 Compare March 31, 2026 17:30
Copy link
Copy Markdown
Collaborator Author

@forsyth2 forsyth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged #788 and rebased this branch off the latest main. By visual inspection, the relevant code changes of the previous commit (which was tested in the 3/27 main branch test) are still in place. I will merge this now.

@forsyth2 forsyth2 merged commit 0ad4774 into main Mar 31, 2026
7 checks passed
@forsyth2 forsyth2 deleted the fix-legacy-310-tests branch March 31, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: bug Bug fix (will increment patch version) Testing Files in `tests` modified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant