Code refactor; adds more tests

.ansible-lint

@@ -0,0 +1,20 @@
+---
+# .ansible-lint
+exclude_paths:
+  - "*.yml.swp"
+  - .ansible/
+  - .cache/  # implicit unless exclude_paths is defined in config
+# Ansible-lint does not automatically load rules that have the 'opt-in' tag.
+# You must enable opt-in rules by listing each rule 'id' below.
+enable_list:
+  - args
+  - empty-string-compare  # opt-in
+  - no-log-password  # opt-in
+  - no-same-owner  # opt-in
+  # - name[prefix] # opt-in
+  # add yaml here if you want to avoid ignoring yaml checks when yamllint
+  # library is missing. Normally its absence just skips using that rule.
+  - yaml
+mock_roles:
+  - community.docker.docker_image
+verbosity: 0

.ansible.cfg

@@ -6,7 +6,8 @@ bin_ansible_callbacks = True
 # Leave the 'cows' alone!
 nocows = 1
 # Use the YAML callback plugin.
-stdout_callback = yaml
+stdout_callback = default
+callback_result_format = yaml
 
 [diff]
 # Always print diff when running (same as always running with -D/--diff).

.coderabbit.yaml

@@ -0,0 +1,50 @@
+---
+# CodeRabbit configuration
+chat:
+  auto_reply: true
+early_access: true
+reviews:
+  auto_review:
+    base_branches:
+      - "dev*"
+      - "main"
+      - "master"
+    drafts: false
+    enabled: true
+    ignore_title_keywords:
+      - "WIP"
+      - "DO NOT MERGE"
+  high_level_summary: true
+  path_filters:
+    - "**/*.j2"
+    - "**/*.md"
+    - "**/*.py"
+    - "**/*.yaml"
+    - "**/*.yml"
+    - "defaults/**"
+    - "meta/**"
+    - "molecule/**"
+    - "tasks/**"
+    - "vars/**"
+  path_instructions:
+    - path: "**/*.yml"
+      instructions: |
+        - For Ansible files, review the YAML code against the Ansible best practices and point out any mismatches.
+        - Ensure keys are in lexicographical order when possible.
+  poem: true
+  request_changes_workflow: false
+  review_status: true
+  tools:
+    actionlint:
+      enabled: true
+    gitleaks:
+      enabled: true
+    hadolint:
+      enabled: true
+    markdownlint:
+      enabled: true
+    shellcheck:
+      enabled: true
+    yamllint:
+      enabled: true
+version: 1

.devcontainer/devcontainer.json

@@ -0,0 +1,57 @@
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the
+// README at: https://github.com/devcontainers/templates/tree/main/src/ubuntu
+{
+
+    // "build": {
+    // "dockerfile": "Dockerfile",
+    // Update 'VARIANT' to pick an Ubuntu version: jammy / ubuntu-22.04, focal / ubuntu-20.04, bionic /ubuntu-18.04
+    // Use ubuntu-22.04 or ubuntu-18.04 on local arm64/Apple Silicon.
+    // "args": { "VARIANT": "ubuntu-22.04" }
+    // },
+
+  // Configure tool-specific properties.
+  "customizations": {
+        "vscode": {
+            "extensions": [
+                "DavidAnson.vscode-markdownlint",
+                "GitHub.copilot",
+                "GitHub.copilot-chat",
+                "elagil.pre-commit-helper",
+                "formulahendry.code-runner",
+                "formulahendry.code-runner-copilot",
+                "github.vscode-github-actions",
+                "ms-python.python",
+                "vscodevim.vim"
+            ],
+        }
+    },
+    // Features to add to the dev container. More info: https://containers.dev/features.
+    "features": {
+      // "ghcr.io/maks1ms/devcontainers-features/wine:0": {},
+      "ghcr.io/devcontainers-contrib/features/actionlint:1": {},
+      "ghcr.io/devcontainers-contrib/features/node-asdf:0": {},
+      "ghcr.io/devcontainers-extra/features/pipx-package:1": {},
+      "ghcr.io/devcontainers/features/docker-in-docker:2": {},
+      "ghcr.io/devcontainers/features/python:1": {},
+      "ghcr.io/guiyomh/features/vim:0": {},
+      "ghcr.io/jungaretti/features/make:1": {},
+      "ghcr.io/prulloac/devcontainer-features/pre-commit:1": {},
+      "ghcr.io/jungaretti/features/ripgrep:1": {}
+    },
+
+    // Use 'forwardPorts' to make a list of ports inside the container available locally.
+    // "forwardPorts": [],
+
+    // Use 'postCreateCommand' to run commands after the container is created.
+    // "postCreateCommand": "uname -a",
+
+    // Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
+    "image": "mcr.microsoft.com/devcontainers/base:jammy",
+    "name": "ansible-role-mt-runner",
+    // Install dependencies and pre-commit hooks.
+    "postCreateCommand": "pip install -r .devcontainer/requirements.txt && pre-commit install",
+
+    // Comment out to connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
+    "remoteUser": "vscode",
+    "onCreateCommand": "sudo apt update && sudo apt install -y gh pipx && pipx install --include-deps ansible"
+}

.devcontainer/requirements.txt

@@ -0,0 +1,11 @@
+# Python's requirements
+# Usage: pip install -r requirements.txt
+ansible
+ansible-lint
+docker>=7.1
+jinja2-cli
+molecule
+molecule-docker
+pipenv
+pre-commit
+requests==2.31.0

.github/actionlint-matcher.json

@@ -0,0 +1,17 @@
+{
+  "problemMatcher": [
+    {
+      "owner": "actionlint",
+      "pattern": [
+        {
+          "regexp": "^(?:\\x1b\\[\\d+m)?(.+?)(?:\\x1b\\[\\d+m)*:(?:\\x1b\\[\\d+m)*(\\d+)(?:\\x1b\\[\\d+m)*:(?:\\x1b\\[\\d+m)*(\\d+)(?:\\x1b\\[\\d+m)*: (?:\\x1b\\[\\d+m)*(.+?)(?:\\x1b\\[\\d+m)* \\[(.+?)\\]$",
+          "file": 1,
+          "line": 2,
+          "column": 3,
+          "message": 4,
+          "code": 5
+        }
+      ]
+    }
+  ]
+}

.github/copilot-instructions.md

@@ -0,0 +1,85 @@
+# Copilot Instructions for ansible-role-mt-runner
+
+You are expected to be an expert in:
+
+- Ansible
+- Python
+- Jinja2
+- Molecule
+- Linux (Alpine, Debian/Ubuntu, Nix)
+- YAML
+
+## Code Standards
+
+- Avoid writing trailing whitespace
+- Follow PEP 8 for Python.
+- Include docstrings and type hints where applicable
+- Maintain consistent YAML indentation
+- Optimize for readability first, performance second
+- Prefer modular, DRY approaches and list comprehensions when appropriate
+- Use environment variables for configuration, never hardcode sensitive info
+- Write clean, documented, error-handling code with appropriate logging
+
+## General Approach
+
+- Be accurate, thorough and terse
+- Cite sources at the end, not inline
+- Provide immediate answers with clear explanations
+- Skip repetitive code in responses; use brief snippets showing only changes
+- Suggest alternative solutions beyond conventional approaches
+- Treat the user as an expert
+
+## Ansible Guidelines
+
+- Ensure idempotency in all tasks
+- Ensure indentation is correct, especially for YAML files
+- Follow standard role structure: tasks/, handlers/, templates/, defaults/, meta/
+- Use ansible-lint and write Molecule tests for verification
+- Use descriptive task names and include helpful comments
+
+## Ansible Linting
+
+Ensure enforcing the following rules:
+
+- fqcn[keyword]: Avoid `collections` keyword by using FQCN for all plugins, modules, roles and playbooks
+
+## YAML Guidelines
+
+Ensure the following rules are strictly followed:
+
+- yaml[empty-lines]: Avoid too many blank lines
+- yaml[indentation]: Avoid wrong indentation
+- yaml[line-length]: No long lines (max. 120 characters)
+- yaml[new-line-at-end-of-file]: Enforce new line character at the end of file
+- yaml[truthy]: Truthy value should be one of [false, true]
+- Ensure items are in lexicographical order when possible.
+- When writing inline code, add a new line at the end to maintain proper indentation
+
+## Project Specifics
+
+This role installs and runs trading platform with distribution-specific approaches:
+
+- **Alpine Linux**: Uses apk package manager
+- **Debian/Ubuntu**: Uses apt package manager
+- **Nix**: Uses nix-env in lightweight Nix environments
+
+Notes:
+
+- Project utilizes Codespaces with config file at .devcontainer/devcontainer.json
+  and requirements at .devcontainer/requirements.txt
+- GitHub Actions are used to validate the code by running
+  pre-commit checks (see .pre-commit-config.yaml file) and Molecule (molecule/).
+- Service management uses supervisord across platforms.
+- Formatting rules are defined in .yamllint (YAML) and .markdownlint.yaml (Markdown) files.
+
+### Key Variables
+
+Variables are defined in defaults/main.yml and vars/main.yml files.
+
+Notes:
+
+- On variable changes, update main.yml and README.md files accordingly.
+
+### Testing Approach
+
+- Use Molecule with Docker driver

.github/dependabot.yml

@@ -0,0 +1,12 @@
+# To get started with Dependabot version updates, you'll need to specify which
+# package ecosystems to update and where the package manifests are located.
+# Please see the documentation for more information:
+# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+# https://containers.dev/guide/dependabot
+---
+version: 2
+updates:
+  - package-ecosystem: "devcontainers"
+    directory: "/"
+    schedule:
+      interval: weekly

.github/prompts/code-review.prompt.md

@@ -0,0 +1,72 @@
+# Ansible Role Code Review Guidelines
+
+Your goal is to review Ansible role code
+to ensure it meets high-quality standards and follows best practices.
+
+## Ensure Code Quality
+
+- Follow PEP 8 for Python.
+- Maintain consistent YAML indentation.
+- Optimize for readability first, performance second.
+- Ensure idempotency in all Ansible tasks.
+- Use environment variables for configuration, never hardcode sensitive info.
+- Write clean, documented, error-handling code with appropriate logging.
+
+## Check for Linting and Formatting
+
+- Ensure YAML files adhere to [.yamllint](../../.yamllint) rules.
+- Ensure Markdown files adhere to [.markdownlint.yaml](../../.markdownlint.yaml) rules.
+- Ensure Ansible playbooks and roles pass `ansible-lint`.
+
+## Review Ansible Role Structure
+
+- Follow standard role structure:
+
+  - [tasks/](../../tasks/)
+  - [handlers/](../../handlers/)
+  - [templates/](../../templates/)
+  - [defaults/](../../defaults/)
+  - [meta/](../../meta/)
+
+- Use descriptive task names and include helpful comments.
+- Ensure indentation is correct, especially for arguments used for Ansible modules.
+
+## Verify Variables and Defaults
+
+- Ensure variables are defined in
+  [defaults/main.yml](../../defaults/main.yml) and [vars/main.yml](../../vars/main.yml).
+- Update [README.md](../../README.md) with any changes to variables.
+- Ensure variables are used consistently across tasks and playbooks.
+
+## Check for Idempotency
+
+- Ensure all tasks are idempotent and do not cause unnecessary changes on repeated runs.
+
+## Review Molecule Tests
+
+- Ensure Molecule scenarios are defined and cover all supported platforms.
+- Verify that Molecule tests are comprehensive and validate the role's functionality.
+- Check [molecule/](../../molecule/) directory for test configurations.
+
+## Ensure Proper Error Handling
+
+- Write error-handling code with appropriate logging.
+- Ensure tasks fail gracefully and provide meaningful error messages.
+
+## Check for Dependencies
+
+- Ensure all dependencies are listed in
+  [.devcontainer/requirements.txt](../../.devcontainer/requirements.txt) and [requirements.yml](../../requirements.yml).
+- Verify that the role does not have any missing dependencies.
+
+## Review GitHub Actions
+
+- Ensure GitHub Actions workflows are correctly configured to run pre-commit checks and Molecule tests.
+- Verify that the workflows cover all necessary validation steps.
+- Check [.github/workflows/](../) directory for workflow configurations.
+
+## Documentation
+
+- Ensure the [README.md](../../README.md) file is up-to-date
+  and provides clear instructions for installation, usage, and variables.
+- Include any additional documentation as needed for clarity.

.github/workflows/check.yml

@@ -7,7 +7,18 @@ on:
   push:
 
 jobs:
-  Pre-commit:
+  actionlint:
+    name: actionlint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: reviewdog/action-actionlint@v1
+      - name: Add Problem Matcher for actionlint
+        run: |
+          echo "::add-matcher::.github/actionlint-matcher.json"
+        shell: bash
+  pre-commit:
+    name: Pre-commit
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -16,4 +27,4 @@ jobs:
           path: ~/.cache/pre-commit
           key: pre-commit|${{ hashFiles('.pre-commit-config.yaml') }}
       - uses: actions/setup-python@v5
-      - uses: pre-commit/action@v3.0.0
+      - uses: pre-commit/action@v3.0.1