Skip to content

Remove record summary from response #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dglemos merged 1 commit into from
Mar 10, 2026
Merged

Remove record summary from response #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions gene2phenotype_project/gene2phenotype_app/serializers/locus_genotype_disease.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ class LocusGenotypeDiseaseSerializer(serializers.ModelSerializer):
Serializer for the LocusGenotypeDisease model.
LocusGenotypeDisease represents a unique Locus-Genotype-Mechanism-Disease-Evidence (LGMDE) record.
"""
summary = serializers.SerializerMethodField(read_only=True)
locus = serializers.SerializerMethodField() # part of the unique entry
stable_id = serializers.CharField(
source="stable_id.stable_id", read_only=True
Expand All @@ -192,13 +191,6 @@ class LocusGenotypeDiseaseSerializer(serializers.ModelSerializer):
comments = serializers.SerializerMethodField(allow_null=True)
is_reviewed = serializers.SerializerMethodField()

def get_summary(self, id: int) -> Optional[str]:
"""
Summary of the LGMDE record.
The summary is automatically generated using the record's data.
"""
return build_lgd_summary(id)

def get_locus(self, id: int) -> dict[str, Any]:
"""
Gene associated with the LGMDE record
Expand Down
4 changes: 0 additions & 4 deletions gene2phenotype_project/gene2phenotype_app/tests/views/test_locus_genotype_disease.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,6 @@ def test_lgd_detail(self):
self.assertEqual(response.data["last_updated"], "2017-04-24")
self.assertEqual(response.data["date_created"], None)

self.assertEqual(response.data["summary"], "There is definitive evidence, " \
"from 1 publication that CEP290 is related to JOUBERT SYNDROME TYPE 5. " \
"This is a biallelic autosomal condition with an evidence loss of function molecular mechanism.")

expected_data_comments = [
{
"id": 2,
Expand Down
4 changes: 0 additions & 4 deletions gene2phenotype_project/gene2phenotype_app/views/locus_genotype_disease.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,10 +228,6 @@ def get(self, request, *args, **kwargs):
"Example 1",
description="Fetch detailed information for record with stable_id G2P03507",
value={
"summary": "There is definitive evidence, from 5 publications that MTFMT is related"
" to mitochondrial disease with regression and lactic acidosis. This is a biallelic autosomal"
" condition with inferred variant consequences of absent gene product, altered gene product"
" structure and an evidence loss of function molecular mechanism.",
"locus": {
"gene_symbol": "MTFMT",
"sequence": "15",
Expand Down
2 changes: 1 addition & 1 deletion gene2phenotype_project/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"openapi": "3.0.3",
"info": {
"title": "Gene2Phenotype (G2P)",
"version": "13.0.0",
"version": "15.0.0",
"description": "This API enables access to gene disease models held in the G2P database. See [https://www.ebi.ac.uk/gene2phenotype/](https://www.ebi.ac.uk/gene2phenotype/) for more details.<br><br>Contact us by submitting an issue via [https://github.com/EBI-G2P/gene2phenotype_api/issues](https://github.com/EBI-G2P/gene2phenotype_api/issues)."
},
"paths": {
Expand Down