-
Notifications
You must be signed in to change notification settings - Fork 22
fix drep-subwf #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29329e2
to
67de2af
Compare
1cac660
to
3c2206c
Compare
a728b51
to
71c650c
Compare
1cb97fa
to
ec32059
Compare
This subwf was also updated in further branch prepare-output, but subwf still doesn't work as part of pipeline (separate steps work) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Drep-subwf:
I tried to decrease number of returning files and intermediate copies
ex:
Also this script creates mash files in mash_folder (as classify_drep step did before)
3) classify_drep uses text file to create many_genomes and one_genome folders. It does nothing with mash files
- GUNC
One-genome-subwf doesn't return all files with GUNC decisions (_complete.txt or _empty.txt). There is a step that generates two reports about complete genomes and genomes that didn't pass filtering.
- GTDB-Tk and rRNA input folder
Drep step doesn't return folder with dereplicated genomes. It returns Sdb.csv with scores. Those scores will be used to identify cluster representative in each cluster.
Added step to identify list of dreplicated genomes and genomes that passed GUNC filtering. Script takes split_text file from drep-subwf and identifies many-genomes clusters and genomes. Then using Sdb.csv script detects the best cluster representative. Those chosen genomes come to list of drep-filtered genomes.
Also script adds genomes from GUNC-report that passed filtering. Finally, this step creates folder with drep-filtered+GUNC-passed genomes. This folder goes as input to GTDB-Tk and rRNA detection.
Issues:
Reduce bind mounting (and thus --bind args) in containers. common-workflow-language/cwltool#1387
Solution:
generate_extra_weight_table step is running without container