chore(combinegenecaller): Add params to support tool version strings#146
Merged
mberacochea merged 8 commits intoEBI-Metagenomics:mainfrom Feb 24, 2026
Conversation
mberacochea
requested changes
Feb 24, 2026
Co-authored-by: Martín Beracochea <mbc@ebi.ac.uk>
Co-authored-by: Martín Beracochea <mbc@ebi.ac.uk>
Contributor
Author
SantiagoSanchezF
left a comment
SantiagoSanchezF
left a comment
There was a problem hiding this comment.
Thanks for the suggestions. I've committed them
Contributor
Author
SantiagoSanchezF
left a comment
SantiagoSanchezF
left a comment
There was a problem hiding this comment.
Making sure no suggested changes remain
…l version for GFFs `source` column
mberacochea
approved these changes
Feb 24, 2026
Member
mberacochea
left a comment
mberacochea
left a comment
There was a problem hiding this comment.
🥇 @SantiagoSanchezF , thanks!
SantiagoSanchezF
deleted the
chore/combinegenecaller_add_params_to_support_tool_version_strings
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the parameter needed so that the python worker can support the tool version strings
Context
Changes to the worker where made to have better annotation if the GFF files
sourcecolumnBreaking changes
The parameter are optional for backwars compatibility.
If provided, thay will change the value annotated in column 2 of the GFF
TODO:
Need to update the contaner version. I'm adding this PR to speed up reviewing process