Conversation
| } | ||
| } | ||
|
|
||
| private class ExcludeFilter { |
Check notice
Code scanning / CodeQL
Inner class could be static Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
The best way to fix this issue is to declare the ExcludeFilter class as a static nested class. Specifically, in OlsSolrQuery.java (lines 181–192), replace the private class ExcludeFilter { ... } declaration with private static class ExcludeFilter { ... }. This ensures that instances of ExcludeFilter do not hold an implicit reference to an instance of the outer OlsSolrQuery class. No changes to methods, imports, or functionality are required, as ExcludeFilter does not access any instance members of the enclosing class.
Suggested changeset
1
backend/src/main/java/uk/ac/ebi/spot/ols/repository/solr/OlsSolrQuery.java
| @@ -178,7 +178,7 @@ | ||
| } | ||
| } | ||
|
|
||
| private class ExcludeFilter { | ||
| private static class ExcludeFilter { | ||
|
|
||
| String propertyName; | ||
| Collection<String> propertyValues; // all values to exclude ("OR") |
Copilot is powered by AI and may make mistakes. Always verify output.
Collaborator
Author
henrietteharmse
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #1021