Skip to content

Comments

Added missing SSSOM predicates#1143

Merged
henrietteharmse merged 5 commits intodevfrom
sssom_predicates_update
Jan 19, 2026
Merged

Added missing SSSOM predicates#1143
henrietteharmse merged 5 commits intodevfrom
sssom_predicates_update

Conversation

@henrietteharmse
Copy link
Collaborator

No description provided.


if(!existingNs.equals(curieNamespace)) {

String origCurieForDebugLog = curiePrefix;

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'String origCurieForDebugLog' is never read.

Copilot Autofix

AI about 1 month ago

In general, an unread local variable should either be removed or used. Since origCurieForDebugLog is only relevant to a commented-out debug print and has no other role, the most straightforward fix that preserves existing functionality is to delete its declaration.

Concretely, in dataload/extras/json2sssom/src/main/java/CurieMap.java, within the second occurrence of the block that handles if (!existingNs.equals(curieNamespace)), remove the line:

String origCurieForDebugLog = curiePrefix;

No additional imports, methods, or definitions are needed. This change does not alter any runtime behavior because the variable was never read.

Suggested changeset 1
dataload/extras/json2sssom/src/main/java/CurieMap.java

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/dataload/extras/json2sssom/src/main/java/CurieMap.java b/dataload/extras/json2sssom/src/main/java/CurieMap.java
--- a/dataload/extras/json2sssom/src/main/java/CurieMap.java
+++ b/dataload/extras/json2sssom/src/main/java/CurieMap.java
@@ -214,8 +214,6 @@
 
             if(!existingNs.equals(curieNamespace)) {
 
-                String origCurieForDebugLog = curiePrefix;
-
                 // try to find a different curie prefix for this namespace
                 String nsToCp = namespaceToCuriePrefix.get(curieNamespace);
                 if(nsToCp != null) {
EOF
@@ -214,8 +214,6 @@

if(!existingNs.equals(curieNamespace)) {

String origCurieForDebugLog = curiePrefix;

// try to find a different curie prefix for this namespace
String nsToCp = namespaceToCuriePrefix.get(curieNamespace);
if(nsToCp != null) {
Copilot is powered by AI and may make mistakes. Always verify output.
@henrietteharmse henrietteharmse merged commit 5f93bba into dev Jan 19, 2026
13 checks passed
@henrietteharmse henrietteharmse deleted the sssom_predicates_update branch January 19, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant