Closed
Conversation
khetherin
force-pushed
the
refactor_and_cleanup
branch
from
f8fb965 to
3a16ba1
Compare
… get_pragma_tokens and get pragma_name_and_values. shortened function names for ease of use. edit tests
tcezard
force-pushed
the
refactor_and_cleanup
branch
from
0a5c661 to
4526a18
Compare
tcezard
reviewed
Oct 22, 2025
| gvf_attribute_dictionary[attribute_key] = attribute_value | ||
| return gvf_attribute_dictionary | ||
|
|
||
| class Assistingconverter: |
Member
There was a problem hiding this comment.
convert_gvf_attributes_to_vcf_values does not need to be in a class
| @@ -0,0 +1,25 @@ | |||
| # helpers.py is to prevent circular imports | |||
Member
There was a problem hiding this comment.
Why don't you put generate_custom_structured_meta_line in assistingconverter.py and remove helpers.py ?
Co-authored-by: Timothee Cezard <tcezard@ebi.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.