Conversation
… get_pragma_tokens and get pragma_name_and_values. shortened function names for ease of use. edit tests
Co-authored-by: Timothee Cezard <tcezard@ebi.ac.uk>
…istingconverter.py and removed the class for Asssisting converter
tcezard
approved these changes
Oct 27, 2025
Member
tcezard
left a comment
tcezard
left a comment
There was a problem hiding this comment.
The refactor makes senses although there are still some area of the code that are a bit messy.
The INFO tag mapping mechanism also makes sense but do makes sure that it does not become overly complicated again.
Comment on lines
+74
to
+76
| # if the attributes is in the INFOattributes.tsv add to INFO dictionary | ||
| # else if attirbute is in attribute_mapper.tsv add to its specific dictionary (INFO/FORMAT) | ||
| # else if attribute is a specific case, deal with appropriately. |
Member
There was a problem hiding this comment.
I'm still a bit unsure why we have two source of mapping INFOattributes.tsv and attribute_mapper.tsv
What is there respective roles ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add custom info tag and addressed comments in review.