Skip to content

Fixes and improvements #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes and improvements #5

wants to merge 4 commits into from

Conversation

mplatov
Copy link

@mplatov mplatov commented May 1, 2020

In this pull request:

  1. Added attributedDescriptionText property to set bubble description with attributed string (with custom attributes for words in the string)
  2. The bubble was flickering due to redraw even if device rotates slightly. Switch to different api to fix this flickering. Also there was a crash if the bubble has no arrow.
  3. Added optional confirmation alert dialog for skip button. Texts for the dialog can be specified via optional properties.
  4. Added configuration options to make dialog dismissible by tapping on the bubble itself or background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mamunx mamunx mamunx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mplatov @mamunx