Skip to content

Update to ArborX 2.0 #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aprokop wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update to ArborX 2.0 #814

aprokop wants to merge 2 commits into from
+15 −15

Conversation

@aprokop
Copy link
Collaborator

@aprokop aprokop commented Apr 17, 2025

No description provided.

dalg24
dalg24 reviewed Apr 17, 2025
View reviewed changes
.github/workflows/CI.yml
cmake_build_type: 'Release'
kokkos_ver: '4.3.00'
arborx: 'fee3d777c0325a90ab50671fca69f2dc98f2a882'
arborx: 'v2.0'
Copy link
Collaborator

@dalg24 dalg24 Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't arborx 2.0 require Kokkos 4.5?

Copy link
Collaborator Author

@aprokop aprokop Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I switched Kokkos versions.

@aprokop
Copy link
Collaborator Author

aprokop commented Dec 1, 2025

Rebased on current master.

@aprokop
Copy link
Collaborator Author

aprokop commented Dec 2, 2025

One job failed for seemingly unrelated reasons:

/github/home/heffte/include/stock_fft/heffte_stock_allocator.h:41:70: error: 'const_pointer' in 'class std::allocator<void>' does not name a type
   41 |         pointer allocate(size_type n, typename std::allocator<void>::const_pointer = nullptr) {
...
/github/home/ALL/include/ALL_Point.hpp:116:3: error: template-id not allowed for destructor
  116 |   ~Point<T>(){};
      |   ^

However, it seems to fail only in this PR. I'm confused.

@streeve streeve mentioned this pull request Jan 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalg24 dalg24 dalg24 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aprokop @dalg24