-
Notifications
You must be signed in to change notification settings - Fork 16
Allow end users to add a family name to the EESSI module #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This was changed in #41, but for some reason the CI in that PR didn't catch it (cc @ocaisa ). edit: ah, I think it's using the modulefile from the CVMFS repo. Now that #41 is deployed, it's failing. https://github.com/EESSI/software-layer-scripts/blob/main/init/lmod/bash#L7 |
I fixed that CI in #42 but you are right that if possible it should actually be being run with the module file in the repository (might be tricky to do in practice) |
Co-authored-by: ocaisa <[email protected]>
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:x86_64/amd/zen2 |
|
New job on instance
|
|
New job on instance
|
ocaisa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I'm not going to worry about the failing CI, this is fixed in #42 |
Assuming sites have a
family("stack")in the meta module for the local stack, this allows them to do the following: