Fix upload for multiple GPU targets #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue reported here EESSI/eessi-bot-software-layer#333 which didn't turn out to be a bot issue, but a naming issue: if the names (excluding timestamp) are the same, the bot will only upload the latest (if the upload policy is 'latest'). So, we need to add the GPU architecture in the name, so that if we build e.g. for
zen2+cc70andzen2+cc80, that both are uploaded (and not just the one that was built the latest).Proof that this PR fixes the issue is in casparvl#1 , where I've first reproduced the issue (i.e. you see only one of the two tarballs being deployed). Then, with the fix implemented, I did a rebuild and redeploy, and it deployed both tarballs.