Skip to content

add hook to avoid requiring ncurses static libraries for CMake built with system toolchain #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 4 commits into from
Sep 11, 2025
Merged

add hook to avoid requiring ncurses static libraries for CMake built with system toolchain #81

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45c006b
cmake hook to use ncurses library from EESSI
pescobar Sep 4, 2025
265f2bf
update log messsages in the cmake hook
pescobar Sep 8, 2025
2e9c060
only remove -DCURSES_.*_LIBRARY configure options when building CMake…
boegel Sep 11, 2025
f940c71
Merge pull request #1 from boegel/hook-cmake-system
pescobar Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions eb_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,6 +942,19 @@ def pre_configure_hook_LAMMPS_zen4(self, *args, **kwargs):
else:
raise EasyBuildError("LAMMPS-specific hook triggered for non-LAMMPS easyconfig?!")

def pre_configure_hook_cmake_system(self, *args, **kwargs):
"""
pre-configure hook for cmake built with SYSTEM toolchain:
- unset configopts for cmake easyconfigs using the SYSTEM toolchain
- https://github.com/EESSI/software-layer/issues/1175
"""

if self.name == 'CMake':
if self.toolchain.name == 'system':
print_msg("Unset configopts to use ncurses library from the EESSI compatibility layer")
Copy link
Contributor

@boegel boegel Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use self.log.info here, or print_msg with log=self.log if you want to be very verbose about this.

I would also log what the previous value of configopts was, so it's clear what's being wiped.

Copy link
Contributor Author

@pescobar pescobar Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel I have updated the log messages as suggested

self.cfg['configopts'] = ''
else:
raise EasyBuildError("CMake-specific hook triggered for non-CMake easyconfig?!")

def pre_test_hook(self, *args, **kwargs):
"""Main pre-test hook: trigger custom functions based on software name."""
Expand Down Expand Up @@ -1484,6 +1497,7 @@ def post_easyblock_hook(self, *args, **kwargs):
'LAMMPS': pre_configure_hook_LAMMPS_zen4,
'Score-P': pre_configure_hook_score_p,
'VSEARCH': pre_configure_hook_vsearch,
'CMake': pre_configure_hook_cmake_system,
}

PRE_TEST_HOOKS = {
Expand Down
Loading