DB validator can upgrade domain state & send status emails automagically#213
Closed
DB validator can upgrade domain state & send status emails automagically#213
Conversation
Instead of confusing the usage for PutDomain, we have a separate SetStatus method now to update the status of a particular domain
This change allows multiple "policies" for a particular domain to exist at once in the database. The reason we need this: If someone wants to update or modify their policy while it's still in testing mode, the actual update shouldn't occur until email confirmation has occurred for the new policy. At the same time, we still need to remember this new policy in case the update does occur. People can still update their entry on the list so long as it's in "testing" mode. Once it's in "enforce", it is much harder to change their entry on the list, and for now, we have to go through a manual channel. As a side thing, also removed "GET" functionality from /queue endpoint since no one is consuming it or relying on it.
Now validation will always happen automagically, and it also can promote/demote the state of a domain.
Contributor
Author
|
Closing for now, I don't think this is the right approach given #217. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #212
Also improves the email API a bit, and stores email templates in
templates.go.