Use crypto/rand in place of math/rand for token generation#257
Open
rubicae wants to merge 2 commits intoEFForg:masterfrom
Open
Use crypto/rand in place of math/rand for token generation#257rubicae wants to merge 2 commits intoEFForg:masterfrom
rubicae wants to merge 2 commits intoEFForg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While familiarizing myself with the code, I found that the the token generation function was using
math/rand(docs for math/rand) which statesFor random numbers suitable for security-sensitive work, see the crypto/rand package.Accordingly, I have switched the token generation to use
crypto/rand.