feat: when login, add passsword leaked warning for the user to change… #50

NipunSGeeTH · 2025-09-20T02:53:22Z

… password

Copilot

Pull Request Overview

This PR adds password breach detection functionality that warns users when their password has been found in data breaches using the HaveIBeenPwned API. The warning is displayed after successful login to encourage users to change compromised passwords.

Integrates HaveIBeenPwned API to check for password breaches during login
Displays a warning alert when a compromised password is detected
Implements secure password checking using SHA-1 hash prefix methodology

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.

File	Description
resources/views/livewire/auth/login.blade.php	Adds password breach checking logic and flashes warning message
resources/views/components/layouts/public.blade.php	Displays breach warning alert with auto-dismiss functionality

Comments suppressed due to low confidence (1)

resources/views/livewire/auth/login.blade.php:1

The password breach warning alert is always shown regardless of whether there's a breach warning in the session. Add a condition to only show this alert when session('password_breach_warning') exists.

<?php

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-20T02:55:58Z

resources/views/livewire/auth/login.blade.php

+
+
+


Remove the excessive blank lines (lines 80-83) before the isPasswordPwned method to maintain consistent code formatting.

Suggested change

Copilot · 2025-09-20T02:55:58Z

resources/views/livewire/auth/login.blade.php

+
+
+
+
+
+
+
+
+


Remove the excessive blank lines (lines 104-112) at the end of the class to maintain consistent code formatting.

Suggested change

Copilot · 2025-09-20T02:55:58Z

resources/views/livewire/auth/login.blade.php

+        foreach (explode("\n", $response->body()) as $line) {
+            [$hashSuffix, $count] = explode(':', $line);
+            if ($suffix === trim($hashSuffix)) {
+                return true;
+            }
+        }


The code doesn't handle empty lines or malformed responses from the API. Add validation to ensure $line contains a colon before using explode(':', $line) to prevent potential errors.

Copilot · 2025-09-20T02:55:58Z

resources/views/livewire/auth/login.blade.php

+

Remove the trailing whitespace on line 127 and the unnecessary blank line 128 to maintain clean formatting.

Suggested change

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-20T10:07:14Z

resources/views/livewire/auth/login.blade.php


+        if ($this->isPasswordPwned($this->password)) {
+            // Flash a warning message after successful login
+            session()->flash('password_breach_warning', ' Your password has appeared in a data breach. For your safety, please change it soon.');


The error message has an extra space at the beginning. Remove the leading space before 'Your password'.

Suggested change

session()->flash('password_breach_warning', ' Your password has appeared in a data breach. For your safety, please change it soon.');

session()->flash('password_breach_warning', 'Your password has appeared in a data breach. For your safety, please change it soon.');

Copilot · 2025-09-20T10:07:14Z

resources/views/livewire/auth/login.blade.php

+
+
+
+  protected function isPasswordPwned(string $password): bool


Inconsistent indentation. The method signature should align with other methods in the class (no leading spaces).

Suggested change

protected function isPasswordPwned(string $password): bool

protected function isPasswordPwned(string $password): bool

Copilot · 2025-09-20T10:07:15Z

resources/views/livewire/auth/login.blade.php

+    $prefix = substr($sha1, 0, 5);
+    $suffix = substr($sha1, 5);
+
+    $response = Http::get("https://api.pwnedpasswords.com/range/{$prefix}");


The API call is synchronous and could cause login delays if the service is slow. Consider adding a timeout or making this check asynchronous.

Suggested change

$response = Http::get("https://api.pwnedpasswords.com/range/{$prefix}");

try {

$response = Http::timeout(2)->get("https://api.pwnedpasswords.com/range/{$prefix}");

} catch (\Exception $e) {

return false; // fail-safe on timeout or connection error

}

Copilot · 2025-09-20T10:07:15Z

resources/views/livewire/auth/login.blade.php

+
+
+
+
+
+
+
+


Excessive blank lines after the method. Remove unnecessary empty lines to maintain consistent code formatting.

Suggested change

Copilot · 2025-09-20T10:07:15Z

resources/views/components/layouts/public.blade.php


+
+        <!-- Password Breach Warning Alert -->
+<!-- Password Breach Warning Alert -->


Duplicate comment. The comment on line 174 and 175 are redundant.

Suggested change

Copilot · 2025-09-20T10:07:15Z

resources/views/components/layouts/public.blade.php

+<div class="bg-base-100 rounded-lg w-full max-w-sm p-6 relative shadow-lg">
+
+            <!-- Close button -->
+         <!-- Close button -->


Duplicate comment. Remove one of the redundant 'Close button' comments.

Suggested change

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-20T10:14:43Z

resources/views/livewire/auth/login.blade.php

+    $prefix = substr($sha1, 0, 5);
+    $suffix = substr($sha1, 5);
+
+   try {


Inconsistent indentation - this line should be aligned with the function body using 4 spaces, not 3.

Suggested change

try {

try {

Copilot · 2025-09-20T10:14:44Z

resources/views/livewire/auth/login.blade.php

+
+
+
+
+
+
+
+


Remove the excessive blank lines at the end of the function. Use consistent spacing with at most one blank line.

Suggested change

Copilot · 2025-09-20T10:14:44Z

resources/views/components/layouts/public.blade.php

+
+        <!-- Password Breach Warning Alert -->
+<!-- Password Breach Warning Alert -->
+@if ( session('password_breach_warning'))


Remove the unnecessary space after the opening parenthesis. Should be @if (session('password_breach_warning')).

Suggested change

@if ( session('password_breach_warning'))

@if (session('password_breach_warning'))

feat: when login, add passsword leaked warning for the user to change…

631573e

… password

Copilot AI review requested due to automatic review settings September 20, 2025 02:53

NipunSGeeTH temporarily deployed to Testing September 20, 2025 02:53 — with GitHub Actions Inactive

NipunSGeeTH requested a review from SuhasDissa September 20, 2025 02:55

Copilot AI reviewed Sep 20, 2025

View reviewed changes

feat:add mobile responsive popup warning

7c3d519

NipunSGeeTH temporarily deployed to Testing September 20, 2025 10:06 — with GitHub Actions Inactive

NipunSGeeTH requested a review from Copilot September 20, 2025 10:06

Copilot AI reviewed Sep 20, 2025

View reviewed changes

fix:timeout added to fetch

64b2dde

NipunSGeeTH temporarily deployed to Testing September 20, 2025 10:13 — with GitHub Actions Inactive

NipunSGeeTH requested a review from Copilot September 20, 2025 10:13

Copilot AI reviewed Sep 20, 2025

View reviewed changes

	session()->flash('password_breach_warning', ' Your password has appeared in a data breach. For your safety, please change it soon.');
	session()->flash('password_breach_warning', 'Your password has appeared in a data breach. For your safety, please change it soon.');

	protected function isPasswordPwned(string $password): bool
	protected function isPasswordPwned(string $password): bool

-    $response = Http::get("https://api.pwnedpasswords.com/range/{$prefix}");
+    try {
+        $response = Http::timeout(2)->get("https://api.pwnedpasswords.com/range/{$prefix}");
+    } catch (\Exception $e) {
+        return false; // fail-safe on timeout or connection error
+    }



		<!-- Password Breach Warning Alert -->
		<!-- Password Breach Warning Alert -->

	@if ( session('password_breach_warning'))
	@if (session('password_breach_warning'))

feat: when login, add passsword leaked warning for the user to change… #50

Are you sure you want to change the base?

feat: when login, add passsword leaked warning for the user to change… #50

Uh oh!

Conversation

NipunSGeeTH commented Sep 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!